Skip to content

Commit

Permalink
fix(ci): wheel and sdist artifacts should get uploaded to shared `art…
Browse files Browse the repository at this point in the history
…ifact` dir (#233)

* remove unique names so that the wheel and sdist get uploaded to the artifact directory instead

* updated pypi upload and using legacy pypi url to test

* update condition to trigger pypi for testing

* fix branch name

* remove condition for testing

* update version of gh-action-pypi-publish

* add on.workflow_call.secrets

* remove condition for testing

* check if token exists

* add back condition for upload
  • Loading branch information
erikayasuda authored Oct 18, 2024
1 parent 0b4e7eb commit 2a9c20c
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/build_deploy.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: Build

on:
workflow_call:
secrets:
PYPI_TOKEN:
description: 'A token for accessing PyPI'
required: true
pull_request:
release:
types:
Expand Down Expand Up @@ -62,11 +67,14 @@ jobs:
steps:
- uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
with:
name: artifact-*
name: artifact-sdist
path: dist

- uses: pypa/gh-action-pypi-publish@master
- uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
with:
name: artifact-wheel
path: dist
- uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ secrets.PYPI_TOKEN }}
# To test: repository_url: https://test.pypi.org/legacy/
# To test: repository-url: https://test.pypi.org/legacy/

0 comments on commit 2a9c20c

Please sign in to comment.