Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruby deprecated module #789

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Conversation

KevinFairise2
Copy link
Member

@KevinFairise2 KevinFairise2 commented Oct 19, 2023

What does this PR do?

Remove the dependency on puppetlabs-ruby module
Fix #735

Motivation

Remove dependency on puppetlabs-ruby module which is deprecated and comes with constraints on other modules we would like to upgrade

Additional Notes

Describe your test plan

@KevinFairise2 KevinFairise2 force-pushed the kfairise/remove-ruby-module branch from e667b28 to 2eff9b5 Compare October 19, 2023 14:45
@KevinFairise2 KevinFairise2 marked this pull request as ready for review October 20, 2023 15:22
@KevinFairise2 KevinFairise2 requested a review from a team as a code owner October 20, 2023 15:22
Copy link
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion

manifests/params.pp Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
@KevinFairise2 KevinFairise2 merged commit 1ac783a into main Oct 23, 2023
2 checks passed
@KevinFairise2 KevinFairise2 deleted the kfairise/remove-ruby-module branch October 23, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find alternative for deprecated https://forge.puppet.com/modules/puppetlabs/ruby
2 participants