Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgres custom metrics #78

Closed
wants to merge 6 commits into from
Closed

Add postgres custom metrics #78

wants to merge 6 commits into from

Conversation

ipolishchuk
Copy link

This pull request is a replacement for #69
It fixes a typo in the londiste3 last_seen metric definition and adds another example of a custom metrics tx_duration_92. There are two metrics here postgresql.max_tx_duration - largest transacrion duration, and postgresql.max_query_duration -- largest query duration for active sessions. The tx_duration_92 metrics are for postgres v9.2+
An extra value of tx_duration_92, it provides a working format sample for a metric without descriptor.

@talwai
Copy link
Contributor

talwai commented May 11, 2015

Upstream dd-agent PR: DataDog/dd-agent#1395

@LeoCavaille
Copy link
Member

We probably want to merge this, but re-work it a bit to allow more liberty in defining the custom metrics dictionary rather than enabling pre-written metrics like londiste3_last_seen or tx_duration_92. People should be able to define that in the class and fill the template not the other way around IMO.
Putting it in standby for now and it would probably helped by a refactoring of the classes.
Feel free to use it on top of the current release if needed.

@LeoCavaille LeoCavaille added this to the 2.0.0 milestone Jun 1, 2015
@sethcleveland
Copy link
Contributor

Custom metric support provided here -- #224.

@truthbk
Copy link
Member

truthbk commented Jul 20, 2017

Superceded by #224 - closing. Thanks regardless @ipolishchuk 🙇

@truthbk truthbk closed this Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants