-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Windows NPM setup and make sure it starts #761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but left a small suggestion for consistency with other parameter descriptions
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
5e00d4f
to
640f5ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments about the documentation, but otherwise this looks great!
What does this PR do?
windows_npm_install
when setting up NPM on Windows.Motivation
Additional Notes
It's difficult to do this automatically since we would have to call the
datadog::datadog_agent
class on thedatadog::system_probe
one, so instead we are just documenting this.Describe your test plan
Docs only change.