Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make datadog_agent::service::enable type more general #756

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Make datadog_agent::service::enable type more general #756

merged 2 commits into from
Oct 11, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 10, 2022

What does this PR do?

Generalizes type for datadog_agent::service::enable

Motivation

Fixes #754

@mx-psi mx-psi marked this pull request as ready for review October 10, 2022 15:51
@mx-psi mx-psi requested a review from a team as a code owner October 10, 2022 15:51
KSerrania
KSerrania reviewed Oct 11, 2022
View reviewed changes
manifests/service.pp Outdated Show resolved Hide resolved
@mx-psi mx-psi requested a review from KSerrania October 11, 2022 10:35
@mx-psi mx-psi merged commit a9fc9e5 into main Oct 11, 2022
@mx-psi mx-psi deleted the mx-psi/service-enable branch October 11, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSerrania KSerrania KSerrania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datadog_agent::service_enable should accept "delayed" as a parameter (Windows)
2 participants
@mx-psi @KSerrania