[cassandra, mysql] Add support for max_returned_metrics and dbm options #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgergo
force-pushed
the
dbm
branch
3 times, most recently
from
f5e07bd to
9b588cf
Compare
rgergo
changed the title
mx-psi
reviewed
Oct 6, 2022
There was a problem hiding this comment.
👋 Apologies for the delay. It looks like you will also need to modify the tests for these integrations so that CI passes. You can find the tests on the spec/classes folder
|
thank you for reviewing, and sorry its my first contribution to open source. |
mx-psi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix cassandra integration tags
add max_returned_metrics parameter for cassandra
add dbm paramter for mysql
Motivation
Additional Notes
Describe your test plan