Solr: rely on built-in default metrics #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup based on description at https://docs.datadoghq.com/integrations/solr/?tab=host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup based on description at https://docs.datadoghq.com/integrations/solr/?tab=host
What does this PR do?
Fix a config drift, it seems the template is not in sync with how the metrics are expected to be structured.
Motivation
Recently setup Solr monitoring in Datadog, but only JVM metrics were available when using this puppet integration.
Additional Notes
Describe your test plan
I'm sorry I don't have the biggest insight into how puppet works, I'm hoping for help in regard to testing.