Support AlmaLinux and Rocky Linux with Puppet >= 7.12.0 #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkabrda
changed the title
bkabrda
force-pushed
the
slavek.kabrda/almalinux-rocky
branch
from
56a463c to
890fd71
Compare
albertvaka
approved these changes
Feb 11, 2022
| @@ -26,6 +26,10 @@ | |||
| PERMISSIONS_PROTECTED_FILE = '0600'.freeze | |||
| end | |||
|
|
|||
| def min_puppet_version(version) | |||
There was a problem hiding this comment.
Super nitpicky, but is_puppet_version_greater_than might be more clear? Feel free to ignore if you like the current name better.
There was a problem hiding this comment.
I don't have a strong opinion, but I probably prefer the shorter variant, so I'll keep it as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for AlmaLinux and Rocky Linux with Puppet >= 7.12.0.
Motivation
Additional Notes
Describe your test plan