Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require datadog_agent instead of including it #725

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Require datadog_agent instead of including it #725

merged 5 commits into from
Jan 26, 2022

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Jan 26, 2022 •
edited
Loading

What does this PR do?

  • Make integration classes require datadog_agent instead of include datadog_agent.
  • Fixed kitchen tests that bitrot and expands them a bit to cover the use of integration classes.

Motivation

This ensures the right execution order of the classes.

Additional Notes

Supersedes #193

This is technically a breaking change, but I can't imagine a scenario where the old behaviour is useful.

Describe your test plan

Tests pass.

@albertvaka albertvaka requested a review from a team as a code owner January 26, 2022 13:51
mx-psi
mx-psi approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am not sure about how big of a deal the breaking change is, but I trust your judgement 😄

@albertvaka albertvaka merged commit 0070680 into main Jan 26, 2022
@albertvaka albertvaka deleted the albertvaka/require-not-include branch January 26, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertvaka @mx-psi