Include 'datadog_agent' class in the catalog when using the generic i… #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegration We encountered an issue when using `datadog_agent::integrations::generic` where the `::datadog_agent::_agent_major_version` variable was undefined. It looks like the class was not including the `datadog_agent` class in the catalog like all other integrations: ``` Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Comparison of: Undef Value > Integer, is not possible. Caused by 'Only Strings, Numbers, Timespans, Timestamps, and Versions are comparable'. (file: /<path>/datadog_agent/manifests/integrations/generic.pp, line: 26, column: 45) on node <host> ``` This commit simply adds the include, bringing this integration in line with the rest.
albertvaka
approved these changes
May 12, 2021
There was a problem hiding this comment.
I'm going to merge this for consistency, but I think the right way would be to require the datadog_agent class to be defined instead of just including it. The reason being that when this is the first include of that class in the catalog then it will be initialized with the default parameters. See #193 (which has been unfortunately ignored for a long time) for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntegration
What does this PR do?
This commit includes the
datadog_agentclass in the catalog when usingdatadog_agent::integrations::generic.Motivation
When working with this integration, we received the following error:
We noticed that the integration does not explicitly include
datadog_agentin the catalog like the other integrations.Describe your test plan
No detailed test plan beyond testing the before and after states. Including the class fixed the issue for us and seems to be the most straightforward and consistent solution that follows the general pattern for the integrations.