Msiexec tag array

[alexberry]

What does this PR do?

I spotted a bug with the windows manifest - When the package gets updated with an array of tags, the tags are passed literally on the command line and msiexec opens an interactive help window, hanging puppet.

Motivation

It broke our release (we have had an array of tags before, the issue only affected us when the agent got updated).

Additional Notes

Describe your test plan

1. I branched your module from github to our own repositories, then added it in to our r10k configuration and removed the "mod" declaration from our Puppetfile so that we no longer used the forge version.

2. I tested as-was, and saw the same error. The error was a result of the following msiexec being run:
   Debug: Executing: 'msiexec.exe /qn /norestart /i C:\Windows\temp\datadog-agent-7-7.22.1.amd64.msi /norestart APIKEY=redacted HOSTNAME=websvr3-stag TAGS=["version:Monolith_uk.1.23.0", "env:stag"]'

3. I updated my branch with the code in this PR and ran puppet again, puppet ran successfully and the resultant msiexec was:
   Debug: Executing: 'msiexec.exe /qn /norestart /i C:\Windows\temp\datadog-agent-7-7.22.1.amd64.msi /norestart APIKEY=redacted HOSTNAME=websvr3-stag TAGS="version:Monolith_uk.1.23.0,env:stag"'

4. Finally I updated my branch to remove the second tag, to ensure the functionality works properly with a single member, and the resultant msiexec was:
   Debug: Executing: 'msiexec.exe /qn /norestart /i C:\Windows\temp\datadog-agent-7-7.22.1.amd64.msi /norestart APIKEY=redacted HOSTNAME=websvr3-stag TAGS="version:Monolith_uk.1.23.0"'

Output from both step 3 (array of tags containing more than 1 member) and step 4 (array of tags containing a single member) conforms to datadog's own command-line installation documentation for windows.

[mx-psi]

Thanks for your PR, we definitely missed that! The logic looks good to me, but you will need the linters to pass in order for us to merge this. You can run them using bundle exec rake test as stated by this guide. In particular, it seems the syntax linter has two suggestions that you should address:

❯ bundle exec rake test
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
manifests/windows.pp - WARNING: double quoted string containing no variables on line 14
manifests/windows.pp - WARNING: variable not enclosed in {} on line 15

[alexberry]

Noted, apologies I should have linted before submitting, PR updated with required lint changes.

[mx-psi]

LGTM now 🚀, thanks for fixing the small issues :)