Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise if hostname_extraction_regex doesn't capture hostname #544

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Jul 3, 2019

Accessing m[:hostname] later in the code would raise a less clear IndexError exception if the match group doesn't exist.

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good fix 🙇

@albertvaka albertvaka merged commit 20a2741 into master Jul 10, 2019
@albertvaka albertvaka deleted the albertvaka/check-match-group-exists-1 branch July 10, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants