Support mongodb collection metrics per collection #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jensendw thank you for this improvement! This looks pretty solid. Would you have the time to add a spec test to ensure this doesn't break in the future? Let me know if that's a problem :) Thanks! |
|
@truthbk Done. I also added tests and comments for the additional_metrics since that was missing. |
truthbk
approved these changes
Jul 20, 2017
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
* Support mongodb collection metrics per collection * spec tests and example for mongo collections/additional_metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred to me that there wasn't support for specifying individual collections using the puppet module, this adds that functionality.