Added cacti integration #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sambanks thank you for this. I will fix the CI in the next couple of days and ask you to rebase to the latest master before merging. Any chance you could add some spec tests? We're trying to keep as much of the code as we can spec tested. I'll give you a heads-up once the issue with the CI is addressed. |
|
Sure thing, will do. Let me know when it's up and running again. Cheers |
|
Took me a couple of goes, as it was my first time doing spec tests, but looks good now. |
|
Nice @sambanks! Let's merge this guy in! 🙇 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
Added cacti integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic integration for cacti