Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS protocol, not Git, in .fixtures.yml #229

Conversation

alex-harvey-z3q
Copy link
Contributor

Without this patch applied, many external users will be unable to run
the unit tests.

Without this patch applied, many external users will be unable to run
the unit tests.
@rooprob
Copy link
Contributor

rooprob commented Sep 12, 2016

Hi @alexharv074 can you identify why your build failed. I believe my PR is failing for the same reason.

@alex-harvey-z3q
Copy link
Contributor Author

Try this:

$ git clone git://github.com/puppetlabs/puppetlabs-stdlib.git

If that fails for you, you won't be able to run these tests. You could upload your SSH key at Github to fix the issue.

@rooprob
Copy link
Contributor

rooprob commented Sep 12, 2016

I'm speaking in relation to #231. The build (https://travis-ci.org/DataDog/puppet-datadog-agent/jobs/158592024) checks out all the requirements correctly.

Your build log looks very similar,
https://travis-ci.org/DataDog/puppet-datadog-agent/builds/156100298

Both our travis runs end in:

The command "bundle exec rake test" exited with 1.

I suspect it's the puppet linter warnings towards the end. I'm not getting those locally, and since Gemfile.lock isn't committed, the build system may have a different version.

@rooprob
Copy link
Contributor

rooprob commented Sep 12, 2016

It's actually been fixed here: 5cd38a4 listed here #224

@alex-harvey-z3q
Copy link
Contributor Author

I believe I'm mistaken here. Use of
Git protocol seems to be more common than HTTPS. I recommend not merging this.

@alex-harvey-z3q
Copy link
Contributor Author

Looking at your issue above, this is either coincidence and unrelated, or I'd guess that you may need to look at the ssh keys you're using in the build.

@truthbk
Copy link
Member

truthbk commented Nov 14, 2016

I agree with @alexharv074, I have mostly found git as the protocol to be more common. Closing for now, we might reopen if necessary in the future. Thanks anyway.

@truthbk truthbk closed this Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants