Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redis] support multiple ports for a single host #169

Closed
wants to merge 1 commit into from

Conversation

fzwart
Copy link
Contributor

@fzwart fzwart commented Feb 18, 2016

I've added support for configuring multiple redis instances for a single host.

@truthbk
Copy link
Member

truthbk commented Mar 16, 2016

Hi @fzwart I don't think the actual agent redis check supports an array of ports as a config parameter. Do you run a custom redis check?

BTW, thanks a lot for taking the time to submit this PR.

@truthbk
Copy link
Member

truthbk commented Apr 7, 2016

@fzwart I misread the template, I see what you're doing creating an instance per port. Will need to polish this to avoid breaking any existing configs due to potential backward compatibility issues.

@fzwart
Copy link
Contributor Author

fzwart commented Apr 8, 2016

Hi @truthbk,

Sorry for my late response, would be great if you could eventually merge it!

@truthbk truthbk changed the title support multiple ports for a single host [redis] support multiple ports for a single host Apr 8, 2016
@truthbk
Copy link
Member

truthbk commented Apr 8, 2016

@fzwart I'll be making a small change to make it backward compatible by keeping the port parameter as well and then feeding it to the template. But I'll naturally respect your authorship here. It's a small change and I have to test the manifest anyways, so no worries I can take care of it. Thank you very much, once again.

@truthbk truthbk added this to the 1.7.0 milestone Apr 8, 2016
@truthbk
Copy link
Member

truthbk commented Apr 12, 2016

Included in #176, thanks!

@truthbk truthbk closed this Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants