This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
Add a prometheus exporter #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienBalestra
force-pushed
the
JulienBalestra/state
branch
from
a49389c to
c815f4f
Compare
mfpierre
reviewed
Jun 20, 2018
scripts/update/docs.go
Outdated
| } | ||
| metricFile.Sync() | ||
| glog.Infof("Generated metrics file in %s", metricFile.Name()) | ||
|
|
mfpierre
reviewed
Jun 20, 2018
| Help: "Total number of kubelet probe failures", | ||
| }), | ||
| } | ||
| err := prometheus.Register(s.promVersion) |
There was a problem hiding this comment.
you could remove the error from NewState and use MustRegister instead of Register which would make the program panic if failing, this would clean up all the error handling code as well
There was a problem hiding this comment.
@mfpierre I wasn't sure about that, do you think it worth it ?
Why panic should be better than an error ?
There was a problem hiding this comment.
Don't you exit anyway if it fails?
There was a problem hiding this comment.
Yes but a panic in the middle of my code path sounds weird to me. Don't you think ?
JulienBalestra
force-pushed
the
JulienBalestra/state
branch
from
37f3a17 to
62a81e8
Compare
mfpierre
previously approved these changes
Jun 21, 2018
JulienBalestra
force-pushed
the
JulienBalestra/state
branch
from
62a81e8 to
75c935e
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Register a Prometheus exporter with custom metrics to improve the observability of pupernetes.
This is a part of #54
Additional Notes
This PR should be merged after the huge refactoring in #56