binaries: skip useless downloads (#104)

DataDog · Jul 24, 2018 · 3ef8976 · 3ef8976
1 parent fd84411
commit 3ef8976
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pkg/setup/binary_containerd.go b/pkg/setup/binary_containerd.go
@@ -11,6 +11,8 @@ import (
 	"os/exec"
 
 	"github.com/golang/glog"
+
+	"github.com/DataDog/pupernetes/pkg/config"
 )
 
 func (e *Environment) extractContainerd() error {
@@ -32,6 +34,10 @@ func (e *Environment) extractContainerd() error {
 }
 
 func (e *Environment) setupBinaryContainerd() error {
+	if e.containerRuntimeInterface != config.CRIContainerd {
+		glog.V(2).Infof("Skipping the download of containerd: using %q", e.containerRuntimeInterface)
+		return nil
+	}
 	_, err := os.Stat(e.binaryContainerd.binaryABSPath)
 	if err == nil && e.binaryContainerd.isUpToDate() {
 		glog.V(4).Infof("Containerd already setup and up to date: %s", e.binaryContainerd.binaryABSPath)

diff --git a/pkg/setup/binary_runc.go b/pkg/setup/binary_runc.go
@@ -11,6 +11,8 @@ import (
 	"os/exec"
 
 	"github.com/golang/glog"
+
+	"github.com/DataDog/pupernetes/pkg/config"
 )
 
 func (e *Environment) extractRunc() error {
@@ -37,6 +39,10 @@ func (e *Environment) extractRunc() error {
 }
 
 func (e *Environment) setupBinaryRunc() error {
+	if e.containerRuntimeInterface != config.CRIContainerd {
+		glog.V(2).Infof("Skipping the download of runc: using %q", e.containerRuntimeInterface)
+		return nil
+	}
 	_, err := os.Stat(e.binaryRunc.binaryABSPath)
 	if err == nil && e.binaryRunc.isUpToDate() {
 		glog.V(4).Infof("Runc already setup and up to date: %s", e.binaryRunc.binaryABSPath)