Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More prohibition of fp register use #194

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

szegedi
Copy link

@szegedi szegedi commented Jan 24, 2025

See #193 – it tries to whack few more FP register use moles.

JIRA: PROF-11193

@szegedi szegedi added the semver-patch Bug or security fixes, mainly label Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

Overall package size

Self size: 9.56 MB
Deduped: 9.93 MB
No deduping: 9.93 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.4 | 226 kB | 226 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi force-pushed the szegedi/general-regs-only branch from 2cdc5ba to 4334535 Compare January 24, 2025 11:59
@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2025

Benchmarks

Benchmark execution time: 2025-01-24 12:04:27

Comparing candidate commit 4334535 in PR branch szegedi/general-regs-only with baseline commit 7b9cc3b in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 92 metrics, 26 unstable metrics.

scenario:profiler-heavy-load-no-wall-profiler-16

  • 🟥 cpu_system_time [+3.936ms; +15.863ms] or [+3.061%; +12.336%]

scenario:profiler-light-load-with-wall-profiler-20

  • 🟥 cpu_user_time [+1.538ms; +6.420ms] or [+1.527%; +6.373%]

@szegedi szegedi marked this pull request as ready for review January 24, 2025 12:53
@szegedi szegedi requested a review from nsavoire as a code owner January 24, 2025 12:53
@szegedi szegedi merged commit 601d2a1 into main Jan 24, 2025
63 checks passed
@szegedi szegedi deleted the szegedi/general-regs-only branch January 24, 2025 13:13
szegedi added a commit that referenced this pull request Jan 24, 2025
@szegedi szegedi mentioned this pull request Jan 24, 2025
szegedi added a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug or security fixes, mainly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants