-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECI-395 Search Resources for Logging #24
ECI-395 Search Resources for Logging #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm. Had a few nit picks. Would be nice to see what the customer UI experience would be for this if it's possible
@@ -0,0 +1,14 @@ | |||
variable "group_id" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if "service_id" or "service_name"? might be a better name for this? I see "group_id" as an OCI Group's OCID (eg. DatadogAuthGroup
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of this variable is to specify Unique Name for the group of resource types
. It doesn't really have to be associated to a service id. The purpose here is to provide any string (it may not even be a service id).
This ensures that the abstraction for any caller code to use resourcediscovery
module is as simple as possible (all you need to provide is compartment ocid and list of resource types).
…rch_logging_resources
What
Why
Testing
Docs Notes