Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECI-395 Search Resources for Logging #24

Merged

Conversation

sva91
Copy link
Contributor

@sva91 sva91 commented Dec 26, 2024

What

  • Add Exclude_Services multi-select enum for users to skip forwarding logs from some services
  • Add Compartments_CSV file upload option to enable users specify compartments for log forwarding. By using csv, we have enabled compartment level configurations by the user.
  • For all supported logging services that aren't excluded, identify resources in all compartments specified by the user.

Why

  • Enable log forwarding in OCI

Testing

Docs Notes

  • It might be preferred to separate the plan and apply stage. Plan stage will identify all resources from which logs should be forwarded.
  • When applying a stack, select a previously successful plan job, instead of applying from beginning so that we can separate resource discovery from resource creation.

@sva91 sva91 changed the title Sva91/search logging resources ECI-395 Search Resources for Logging Dec 26, 2024
@sva91 sva91 marked this pull request as ready for review December 26, 2024 22:27
@sva91 sva91 requested a review from a team December 26, 2024 22:27
@sva91 sva91 added the eci label Dec 26, 2024
Copy link
Contributor

@bengillmandd bengillmandd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm. Had a few nit picks. Would be nice to see what the customer UI experience would be for this if it's possible

@@ -0,0 +1,14 @@
variable "group_id" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if "service_id" or "service_name"? might be a better name for this? I see "group_id" as an OCI Group's OCID (eg. DatadogAuthGroup)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this variable is to specify Unique Name for the group of resource types. It doesn't really have to be associated to a service id. The purpose here is to provide any string (it may not even be a service id).

This ensures that the abstraction for any caller code to use resourcediscovery module is as simple as possible (all you need to provide is compartment ocid and list of resource types).

@sva91 sva91 merged commit 178ccf0 into sva91/log_forwarding_automation_modules Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants