Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Object view #341

Draft
wants to merge 51 commits into
base: master
Choose a base branch
from
Draft

[WIP] Object view #341

wants to merge 51 commits into from

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Oct 1, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 89.13043% with 30 lines in your changes missing coverage. Please review.

Project coverage is 85.10%. Comparing base (781d86b) to head (3dfb515).

Files with missing lines Patch % Lines
src/object_view.hpp 86.27% 3 Missing and 11 partials ⚠️
src/iterator.cpp 92.00% 0 Missing and 10 partials ⚠️
src/iterator.hpp 68.75% 2 Missing and 3 partials ⚠️
src/condition/match_iterator.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   85.13%   85.10%   -0.03%     
==========================================
  Files         164      166       +2     
  Lines        8232     8340     +108     
  Branches     3609     3647      +38     
==========================================
+ Hits         7008     7098      +90     
- Misses        462      465       +3     
- Partials      762      777      +15     
Flag Coverage Δ
waf_test 85.10% <89.13%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024

Benchmarks

Benchmark execution time: 2025-02-19 13:37:02

Comparing candidate commit 3dfb515 in PR branch anilm3/object_view with baseline commit 781d86b in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random

  • 🟥 execution_time [+14.348ms; +14.362ms] or [+5.287%; +5.292%]

@Anilm3 Anilm3 force-pushed the anilm3/object_view branch from 63d6557 to 98c50a8 Compare October 3, 2024 18:23
@Anilm3 Anilm3 changed the base branch from master to anilm3/v2 October 9, 2024 09:36
@Anilm3 Anilm3 force-pushed the anilm3/object_view branch from 5bb6c6e to fdadce8 Compare October 21, 2024 20:37
@Anilm3 Anilm3 changed the base branch from anilm3/v2 to master February 18, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants