-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crashtracker] Enable the client to register arbitrary messages #847
Conversation
BenchmarksComparisonBenchmark execution time: 2025-02-04 19:28:42 Comparing candidate commit 099d19e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 71.63% 71.60% -0.04%
==========================================
Files 317 320 +3
Lines 46745 46923 +178
==========================================
+ Hits 33487 33597 +110
- Misses 13258 13326 +68
|
) * Add a `unintern_all` bulk operation for managed string storage This allows us to avoid crossing the FFI boundary and grabbing the lock too often whenever there's a bunch of ids to be uninterned. * Add an `intern_all` bulk operation for managed string storage This allows us to avoid crossing the FFI boundary and grabbing the lock too often whenever there's a bunch of ids to be interned. * refactor and test --------- Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com>
* fix: tolerate empty trace payload body * add tests to cover empty msgpack arrays as trace payloads * add miri ignore to empty payload test --------- Co-authored-by: Edmund Kump <edmund.kump@datadoghq.com>
What does this PR do?
Adds a new capability where the client can temporary add strings which will go on the crash report. For e.g. a program might register information about its doing when it starts a potentially crashing operation.
Motivation
Request from the PHP team
Additional Notes
If its useful, I could consider moving the new data-structure to the common crate.
How to test the change?
Run
crashtracking.c
, notice how the output now includes