Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Refactor: Use the new FFI helper macros to cleanup the code #793

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Dec 9, 2024

What does this PR do?

Uses the macros introduced in #752 throught the rest of crashtracker

Motivation

Just look at how much nicer the code is.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-12-09 19:59:22

Comparing candidate commit 0008802 in PR branch dsn/use-wrap-macro with baseline commit 189269d in branch main.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟩 execution_time [-2.830ms; -2.759ms] or [-4.582%; -4.466%]

scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて

  • 🟩 execution_time [-29.630µs; -29.411µs] or [-5.995%; -5.951%]
  • 🟩 throughput [+128056.161op/s; +129043.249op/s] or [+6.329%; +6.377%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.073µs 38.564µs ± 0.756µs 38.223µs ± 0.081µs 38.343µs 40.160µs 40.197µs 41.324µs 8.11% 1.728 1.256 1.95% 0.053µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.460µs; 38.669µs] or [-0.272%; +0.272%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 72.642µs 72.860µs ± 0.217µs 72.817µs ± 0.055µs 72.879µs 73.191µs 73.379µs 75.185µs 3.25% 6.641 64.983 0.30% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [72.830µs; 72.890µs] or [-0.041%; +0.041%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.710ms 58.972ms ± 0.173ms 58.957ms ± 0.067ms 59.012ms 59.289ms 59.713ms 60.017ms 1.80% 2.674 10.311 0.29% 0.012ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.948ms; 58.996ms] or [-0.041%; +0.041%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 626.130µs 627.359µs ± 0.645µs 627.308µs ± 0.268µs 627.604µs 628.026µs 628.290µs 634.426µs 1.13% 6.542 70.078 0.10% 0.046µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1576227.605op/s 1593984.414op/s ± 1629.105op/s 1594113.712op/s ± 680.592op/s 1594724.424op/s 1595611.940op/s 1596815.616op/s 1597113.696op/s 0.19% -6.452 68.809 0.10% 115.195op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 463.438µs 464.684µs ± 0.714µs 464.627µs ± 0.270µs 464.896µs 465.328µs 465.819µs 470.982µs 1.37% 5.713 45.949 0.15% 0.051µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2123221.257op/s 2152004.938op/s ± 3279.825op/s 2152263.830op/s ± 1248.274op/s 2153510.747op/s 2155071.089op/s 2156477.479op/s 2157784.469op/s 0.26% -5.643 45.186 0.15% 231.919op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.373µs 179.975µs ± 0.470µs 179.911µs ± 0.242µs 180.152µs 180.625µs 181.609µs 183.575µs 2.04% 3.614 21.776 0.26% 0.033µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5447367.732op/s 5556360.635op/s ± 14382.232op/s 5558302.701op/s ± 7452.582op/s 5565684.650op/s 5569557.866op/s 5572450.305op/s 5574987.939op/s 0.30% -3.532 20.970 0.26% 1016.977op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.524µs 47.686µs ± 0.057µs 47.687µs ± 0.037µs 47.724µs 47.778µs 47.846µs 47.880µs 0.41% 0.104 0.722 0.12% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20885569.169op/s 20970546.558op/s ± 25207.979op/s 20970290.831op/s ± 16296.174op/s 20986351.738op/s 21009699.584op/s 21033211.038op/s 21041885.159op/s 0.34% -0.094 0.715 0.12% 1782.473op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.718µs 49.949µs ± 0.164µs 49.922µs ± 0.053µs 49.985µs 50.098µs 50.962µs 51.202µs 2.57% 5.270 35.086 0.33% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19530416.941op/s 20020526.804op/s ± 64555.787op/s 20031394.031op/s ± 21338.403op/s 20048332.613op/s 20075955.417op/s 20093554.822op/s 20113304.951op/s 0.41% -5.179 34.216 0.32% 4564.783op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [627.270µs; 627.449µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1593758.636op/s; 1594210.192op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [464.585µs; 464.783µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2151550.386op/s; 2152459.491op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [179.910µs; 180.040µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5554367.396op/s; 5558353.874op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.678µs; 47.694µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [20967052.975op/s; 20974040.141op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.927µs; 49.972µs] or [-0.045%; +0.045%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20011579.993op/s; 20029473.615op/s] or [-0.045%; +0.045%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.275µs 24.488µs ± 14.092µs 18.897µs ± 0.445µs 19.418µs 45.902µs 49.671µs 160.997µs 751.96% 5.380 44.203 57.40% 0.996µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.535µs; 26.441µs] or [-7.976%; +7.976%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.852ms 6.867ms ± 0.007ms 6.866ms ± 0.004ms 6.870ms 6.876ms 6.886ms 6.918ms 0.76% 2.593 14.889 0.11% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.866ms; 6.868ms] or [-0.015%; +0.015%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.423µs 3.248µs ± 1.439µs 3.093µs ± 0.020µs 3.111µs 3.155µs 14.234µs 15.240µs 392.74% 7.637 58.191 44.18% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.049µs; 3.447µs] or [-6.138%; +6.138%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.173µs 141.699µs ± 0.429µs 141.612µs ± 0.165µs 141.802µs 142.504µs 143.294µs 144.317µs 1.91% 2.996 12.410 0.30% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [141.640µs; 141.758µs] or [-0.042%; +0.042%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 190.811µs 193.278µs ± 0.858µs 193.237µs ± 0.558µs 193.855µs 194.676µs 195.093µs 195.797µs 1.32% -0.001 0.082 0.44% 0.061µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5107336.571op/s 5173993.047op/s ± 22965.572op/s 5174991.683op/s ± 14950.936op/s 5187784.179op/s 5210555.858op/s 5224460.609op/s 5240780.258op/s 1.27% 0.029 0.093 0.44% 1623.911op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.163µs 18.263µs ± 0.053µs 18.263µs ± 0.028µs 18.292µs 18.327µs 18.351µs 18.713µs 2.46% 2.816 23.395 0.29% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53438017.961op/s 54754567.306op/s ± 158959.714op/s 54754370.418op/s ± 84377.166op/s 54838728.631op/s 55015093.906op/s 55044563.410op/s 55057417.021op/s 0.55% -2.666 21.861 0.29% 11240.149op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.057µs 11.118µs ± 0.073µs 11.085µs ± 0.015µs 11.141µs 11.236µs 11.269µs 11.821µs 6.64% 4.956 41.715 0.65% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 84598342.930op/s 89950010.259op/s ± 571586.246op/s 90211871.037op/s ± 120006.871op/s 90286113.523op/s 90342844.043op/s 90375117.121op/s 90442042.549op/s 0.26% -4.600 36.875 0.63% 40417.251op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [193.159µs; 193.397µs] or [-0.062%; +0.062%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5170810.239op/s; 5177175.854op/s] or [-0.062%; +0.062%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.256µs; 18.271µs] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54732537.019op/s; 54776597.594op/s] or [-0.040%; +0.040%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.108µs; 11.128µs] or [-0.091%; +0.091%] None None None
normalization/normalize_name/normalize_name/good throughput [89870793.902op/s; 90029226.615op/s] or [-0.088%; +0.088%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.651µs 2.701µs ± 0.015µs 2.698µs ± 0.004µs 2.704µs 2.731µs 2.747µs 2.760µs 2.30% 0.665 3.319 0.57% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.698µs; 2.703µs] or [-0.079%; +0.079%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 275.192ns 284.601ns ± 13.000ns 278.914ns ± 2.802ns 284.448ns 321.627ns 326.603ns 329.922ns 18.29% 2.097 3.517 4.56% 0.919ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [282.800ns; 286.403ns] or [-0.633%; +0.633%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0008802 1733773713 dsn/use-wrap-macro
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.617µs 4.631µs ± 0.006µs 4.632µs ± 0.003µs 4.635µs 4.640µs 4.643µs 4.685µs 1.15% 2.871 24.014 0.14% 0.000µs 1 200
credit_card/is_card_number/ throughput 213449934.972op/s 215917050.011op/s ± 294170.122op/s 215904235.679op/s ± 156823.178op/s 216096184.412op/s 216337515.771op/s 216522500.696op/s 216589035.541op/s 0.32% -2.799 23.278 0.14% 20800.969op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 95.130µs 95.623µs ± 0.456µs 95.555µs ± 0.177µs 95.787µs 96.073µs 96.232µs 100.969µs 5.67% 8.129 92.377 0.48% 0.032µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 9904027.147op/s 10457937.504op/s ± 48088.263op/s 10465178.688op/s ± 19414.475op/s 10480782.183op/s 10500495.833op/s 10503586.559op/s 10511937.356op/s 0.45% -7.732 86.172 0.46% 3400.354op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 85.540µs 86.186µs ± 0.489µs 86.155µs ± 0.260µs 86.406µs 86.766µs 86.929µs 90.991µs 5.61% 4.773 44.780 0.57% 0.035µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10990047.338op/s 11603171.703op/s ± 64143.373op/s 11607030.588op/s ± 35029.896op/s 11643084.242op/s 11681597.631op/s 11690031.256op/s 11690496.795op/s 0.72% -4.382 39.818 0.55% 4535.621op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.618µs 4.632µs ± 0.006µs 4.632µs ± 0.003µs 4.635µs 4.640µs 4.643µs 4.693µs 1.31% 4.263 39.042 0.14% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 213090652.019op/s 215877925.805op/s ± 295614.687op/s 215876270.517op/s ± 146149.353op/s 216036645.216op/s 216255079.369op/s 216352643.763op/s 216557462.219op/s 0.32% -4.170 37.919 0.14% 20903.115op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 82.256µs 82.785µs ± 0.290µs 82.780µs ± 0.172µs 82.938µs 83.344µs 83.534µs 83.599µs 0.99% 0.552 -0.139 0.35% 0.021µs 1 200
credit_card/is_card_number/378282246310005 throughput 11961929.430op/s 12079650.226op/s ± 42273.139op/s 12080179.471op/s ± 25143.845op/s 12105484.995op/s 12140562.835op/s 12147778.590op/s 12157144.658op/s 0.64% -0.536 -0.163 0.35% 2989.162op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.962µs 59.069µs ± 0.040µs 59.063µs ± 0.013µs 59.081µs 59.125µs 59.152µs 59.360µs 0.50% 3.732 25.092 0.07% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16846262.691op/s 16929406.607op/s ± 11339.581op/s 16931109.854op/s ± 3813.470op/s 16934680.398op/s 16942555.757op/s 16948494.998op/s 16959938.928op/s 0.17% -3.706 24.861 0.07% 801.829op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.838µs 6.847µs ± 0.003µs 6.846µs ± 0.002µs 6.848µs 6.852µs 6.856µs 6.858µs 0.17% 0.783 1.965 0.04% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145825323.421op/s 146059329.818op/s ± 62578.815op/s 146070216.283op/s ± 33655.058op/s 146096135.758op/s 146150844.419op/s 146183635.398op/s 146240083.376op/s 0.12% -0.778 1.957 0.04% 4424.990op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.618µs 4.631µs ± 0.005µs 4.631µs ± 0.003µs 4.633µs 4.638µs 4.642µs 4.643µs 0.26% 0.004 -0.084 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215391862.615op/s 215958053.404op/s ± 217782.315op/s 215959032.575op/s ± 139443.501op/s 216102681.194op/s 216303582.086op/s 216460511.448op/s 216546672.074op/s 0.27% 0.002 -0.084 0.10% 15399.535op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 75.287µs 75.480µs ± 0.071µs 75.482µs ± 0.048µs 75.529µs 75.588µs 75.624µs 75.689µs 0.27% -0.229 0.157 0.09% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13212001.464op/s 13248636.997op/s ± 12469.755op/s 13248114.422op/s ± 8400.137op/s 13257096.060op/s 13267507.675op/s 13280344.056op/s 13282557.346op/s 0.26% 0.235 0.160 0.09% 881.745op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.893µs 66.089µs ± 0.097µs 66.076µs ± 0.059µs 66.138µs 66.293µs 66.357µs 66.407µs 0.50% 0.877 0.797 0.15% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15058559.468op/s 15131175.194op/s ± 22191.640op/s 15134103.091op/s ± 13497.498op/s 15146937.627op/s 15162908.645op/s 15167575.975op/s 15176130.981op/s 0.28% -0.868 0.777 0.15% 1569.186op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.612µs 4.628µs ± 0.006µs 4.629µs ± 0.004µs 4.633µs 4.638µs 4.640µs 4.642µs 0.27% -0.273 -0.381 0.13% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215439877.862op/s 216054882.028op/s ± 276142.333op/s 216025977.143op/s ± 195171.866op/s 216245238.320op/s 216536789.319op/s 216670648.094op/s 216843869.603op/s 0.38% 0.279 -0.377 0.13% 19526.212op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.325µs 62.569µs ± 0.132µs 62.554µs ± 0.069µs 62.631µs 62.758µs 62.866µs 63.706µs 1.84% 3.370 25.808 0.21% 0.009µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15697002.334op/s 15982374.075op/s ± 33564.482op/s 15986080.121op/s ± 17739.991op/s 16002505.196op/s 16023580.301op/s 16038572.063op/s 16044943.491op/s 0.37% -3.268 24.670 0.21% 2373.367op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.018µs 59.070µs ± 0.030µs 59.066µs ± 0.015µs 59.083µs 59.116µs 59.143µs 59.294µs 0.39% 2.802 16.574 0.05% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16865074.346op/s 16928989.902op/s ± 8451.101op/s 16930093.949op/s ± 4427.876op/s 16934394.884op/s 16938225.445op/s 16942726.621op/s 16943957.859op/s 0.08% -2.786 16.420 0.05% 597.583op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.837µs 6.846µs ± 0.003µs 6.846µs ± 0.001µs 6.847µs 6.851µs 6.854µs 6.854µs 0.13% 0.217 0.823 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145893371.218op/s 146074710.759op/s ± 63674.127op/s 146075948.595op/s ± 29800.667op/s 146108368.357op/s 146186475.148op/s 146216584.771op/s 146272543.092op/s 0.13% -0.213 0.822 0.04% 4502.441op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.631µs; 4.632µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/ throughput [215876280.861op/s; 215957819.161op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [95.560µs; 95.686µs] or [-0.066%; +0.066%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10451272.933op/s; 10464602.075op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [86.118µs; 86.254µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11594282.049op/s; 11612061.358op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/37828224631 execution_time [4.631µs; 4.633µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/37828224631 throughput [215836956.452op/s; 215918895.157op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/378282246310005 execution_time [82.745µs; 82.825µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/378282246310005 throughput [12073791.575op/s; 12085508.876op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.063µs; 59.074µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16927835.050op/s; 16930978.164op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.846µs; 6.847µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number/x371413321323331 throughput [146050656.996op/s; 146068002.640op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.630µs; 4.631µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/ throughput [215927870.870op/s; 215988235.939op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [75.470µs; 75.489µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13246908.809op/s; 13250365.186op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.075µs; 66.102µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15128099.647op/s; 15134250.742op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.628µs; 4.629µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216016611.356op/s; 216093152.699op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.551µs; 62.588µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15977722.361op/s; 15987025.790op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.066µs; 59.074µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16927818.661op/s; 16930161.143op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.845µs; 6.846µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146065886.137op/s; 146083535.380op/s] or [-0.006%; +0.006%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 20.28986% with 55 lines in your changes missing coverage. Please review.

Project coverage is 70.78%. Comparing base (189269d) to head (0008802).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   70.65%   70.78%   +0.13%     
==========================================
  Files         313      313              
  Lines       45669    45649      -20     
==========================================
+ Hits        32267    32313      +46     
+ Misses      13402    13336      -66     
Components Coverage Δ
crashtracker 38.27% <15.62%> (+0.21%) ⬆️
crashtracker-ffi 5.71% <15.87%> (+0.05%) ⬆️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.38% <ø> (ø)
data-pipeline-ffi 86.29% <ø> (ø)
ddcommon 81.77% <80.00%> (+0.16%) ⬆️
ddcommon-ffi 65.52% <80.00%> (+0.55%) ⬆️
ddtelemetry 59.51% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (ø)
profiling 84.31% <ø> (+0.69%) ⬆️
profiling-ffi 77.55% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.56% <ø> (ø)
sidecar-ffi 1.18% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.38% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.52% <ø> (ø)

@danielsn danielsn enabled auto-merge (squash) December 9, 2024 19:24
@danielsn danielsn merged commit d111f32 into main Dec 9, 2024
33 checks passed
@danielsn danielsn deleted the dsn/use-wrap-macro branch December 9, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants