Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builder cmake target directory. #776

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix builder cmake target directory. #776

merged 2 commits into from
Dec 3, 2024

Conversation

hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Dec 2, 2024 •
edited
Loading

What does this PR do?

Fix cmake target directory during the artifact generation.

Motivation

The builder could fail on certain scenarios.

How to test the change?

Builder can be triggered by:

cargo run --bin release --features profiling,telemetry,symbolizer,crashtracker,data-pipeline --release -- --out <path>

After that it can be checked that all required artifacts should be in the desired output path

@pr-commenter
Copy link

pr-commenter bot commented Dec 2, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-12-03 10:52:58

Comparing candidate commit 9e24825 in PR branch julio/fix-builder-cmake-path with baseline commit e9e4c06 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 508.346µs 509.405µs ± 0.545µs 509.344µs ± 0.314µs 509.644µs 510.303µs 511.331µs 511.817µs 0.49% 1.319 3.242 0.11% 0.039µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1953824.462op/s 1963077.355op/s ± 2096.414op/s 1963311.256op/s ± 1211.202op/s 1964554.809op/s 1965706.265op/s 1966701.138op/s 1967162.731op/s 0.20% -1.308 3.196 0.11% 148.239op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 465.785µs 466.526µs ± 0.353µs 466.535µs ± 0.261µs 466.769µs 467.109µs 467.366µs 467.543µs 0.22% 0.159 -0.275 0.08% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2138842.872op/s 2143506.575op/s ± 1620.481op/s 2143463.235op/s ± 1201.087op/s 2144800.445op/s 2146152.209op/s 2146792.780op/s 2146912.548op/s 0.16% -0.155 -0.279 0.08% 114.585op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.574µs 176.445µs ± 0.339µs 176.411µs ± 0.245µs 176.693µs 176.998µs 177.155µs 177.356µs 0.54% 0.110 -0.454 0.19% 0.024µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5638375.499op/s 5667519.963op/s ± 10902.379op/s 5668584.677op/s ± 7880.984op/s 5675692.390op/s 5684940.251op/s 5688852.202op/s 5695589.891op/s 0.48% -0.101 -0.456 0.19% 770.915op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.094µs 45.349µs ± 0.116µs 45.341µs ± 0.075µs 45.417µs 45.559µs 45.647µs 45.702µs 0.80% 0.431 0.090 0.26% 0.008µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21880666.569op/s 22051175.201op/s ± 56494.395op/s 22055114.325op/s ± 36502.658op/s 22089533.600op/s 22139515.865op/s 22153364.724op/s 22175822.503op/s 0.55% -0.417 0.071 0.26% 3994.757op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 41.823µs 42.057µs ± 0.296µs 41.978µs ± 0.129µs 42.205µs 42.411µs 42.526µs 45.083µs 7.39% 5.584 52.806 0.70% 0.021µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 22181498.825op/s 23778538.610op/s ± 161216.502op/s 23821757.852op/s ± 73323.846op/s 23886413.991op/s 23905078.271op/s 23908352.546op/s 23910235.416op/s 0.37% -5.111 46.233 0.68% 11399.728op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [509.329µs; 509.480µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1962786.812op/s; 1963367.897op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [466.477µs; 466.574µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2143281.992op/s; 2143731.158op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.398µs; 176.492µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5666008.998op/s; 5669030.928op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.333µs; 45.365µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22043345.621op/s; 22059004.781op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [42.016µs; 42.098µs] or [-0.097%; +0.097%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [23756195.553op/s; 23800881.666op/s] or [-0.094%; +0.094%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.896µs 142.820µs ± 0.583µs 142.750µs ± 0.155µs 142.933µs 143.281µs 143.564µs 150.120µs 5.16% 9.845 120.976 0.41% 0.041µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.739µs; 142.901µs] or [-0.057%; +0.057%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.728µs 24.624µs ± 13.523µs 18.851µs ± 0.055µs 19.114µs 46.733µs 48.557µs 151.938µs 705.98% 5.017 39.336 54.78% 0.956µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.749µs; 26.498µs] or [-7.611%; +7.611%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 72.726µs 72.895µs ± 0.241µs 72.863µs ± 0.046µs 72.914µs 73.055µs 73.203µs 75.989µs 4.29% 10.832 134.105 0.33% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [72.862µs; 72.929µs] or [-0.046%; +0.046%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.406µs 3.250µs ± 1.460µs 3.094µs ± 0.024µs 3.114µs 3.150µs 14.339µs 15.434µs 398.87% 7.649 58.387 44.81% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.048µs; 3.452µs] or [-6.226%; +6.226%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.752ms 58.957ms ± 0.158ms 58.911ms ± 0.062ms 58.995ms 59.282ms 59.455ms 59.999ms 1.85% 2.738 11.686 0.27% 0.011ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.935ms; 58.979ms] or [-0.037%; +0.037%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.658µs 2.715µs ± 0.047µs 2.701µs ± 0.009µs 2.710µs 2.864µs 2.877µs 2.886µs 6.85% 2.286 4.472 1.74% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.709µs; 2.722µs] or [-0.241%; +0.241%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.607µs 4.627µs ± 0.006µs 4.627µs ± 0.004µs 4.631µs 4.638µs 4.641µs 4.653µs 0.56% 0.201 1.335 0.13% 0.000µs 1 200
credit_card/is_card_number/ throughput 214919768.094op/s 216099936.335op/s ± 284408.539op/s 216122595.650op/s ± 170153.668op/s 216264274.468op/s 216530833.569op/s 216757008.770op/s 217078960.990op/s 0.44% -0.188 1.321 0.13% 20110.721op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 96.266µs 96.454µs ± 0.381µs 96.425µs ± 0.026µs 96.455µs 96.512µs 96.546µs 101.752µs 5.52% 13.585 186.613 0.39% 0.027µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 9827823.153op/s 10367781.903op/s ± 38837.306op/s 10370797.390op/s ± 2821.209op/s 10373394.318op/s 10381245.346op/s 10384793.412op/s 10387853.483op/s 0.16% -13.537 185.705 0.37% 2746.212op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 88.312µs 88.752µs ± 0.422µs 88.694µs ± 0.132µs 88.866µs 89.086µs 89.270µs 93.998µs 5.98% 9.663 117.462 0.47% 0.030µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10638561.282op/s 11267533.615op/s ± 51291.307op/s 11274735.573op/s ± 16773.927op/s 11287118.306op/s 11309265.795op/s 11319492.438op/s 11323543.913op/s 0.43% -9.294 111.361 0.45% 3626.843op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.613µs 4.627µs ± 0.007µs 4.627µs ± 0.003µs 4.630µs 4.636µs 4.639µs 4.690µs 1.38% 4.363 40.462 0.14% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 213197328.821op/s 216115080.175op/s ± 306929.422op/s 216130395.206op/s ± 152701.697op/s 216297312.161op/s 216449711.849op/s 216751110.734op/s 216784385.668op/s 0.30% -4.264 39.264 0.14% 21703.188op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 84.704µs 85.429µs ± 0.261µs 85.405µs ± 0.167µs 85.605µs 85.886µs 86.064µs 86.191µs 0.92% 0.226 0.069 0.30% 0.018µs 1 200
credit_card/is_card_number/378282246310005 throughput 11602138.294op/s 11705782.017op/s ± 35735.952op/s 11708863.477op/s ± 22983.296op/s 11729544.148op/s 11759589.417op/s 11784453.517op/s 11805758.849op/s 0.83% -0.208 0.062 0.30% 2526.913op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 64.184µs 64.319µs ± 0.078µs 64.307µs ± 0.024µs 64.334µs 64.396µs 64.656µs 65.058µs 1.17% 5.768 46.755 0.12% 0.005µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 15370954.335op/s 15547558.549op/s ± 18659.027op/s 15550346.965op/s ± 5808.145op/s 15555168.061op/s 15563343.038op/s 15574889.338op/s 15580322.053op/s 0.19% -5.713 46.055 0.12% 1319.392op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.830µs 6.843µs ± 0.004µs 6.843µs ± 0.002µs 6.845µs 6.849µs 6.852µs 6.859µs 0.23% -0.041 1.708 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145803618.283op/s 146139084.756op/s ± 82975.411op/s 146138212.765op/s ± 40280.693op/s 146176863.857op/s 146293274.507op/s 146341350.233op/s 146406916.896op/s 0.18% 0.047 1.702 0.06% 5867.248op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.617µs 4.630µs ± 0.005µs 4.629µs ± 0.004µs 4.633µs 4.638µs 4.642µs 4.644µs 0.32% 0.201 -0.438 0.12% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215326141.918op/s 216001110.207op/s ± 249460.053op/s 216006469.007op/s ± 167578.242op/s 216181516.497op/s 216371714.868op/s 216476843.845op/s 216584393.982op/s 0.27% -0.196 -0.441 0.12% 17639.490op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 76.792µs 77.310µs ± 0.147µs 77.310µs ± 0.096µs 77.417µs 77.520µs 77.585µs 77.695µs 0.50% -0.462 0.383 0.19% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 12870880.613op/s 12934964.991op/s ± 24543.652op/s 12934938.555op/s ± 15982.217op/s 12948030.492op/s 12977198.516op/s 12996476.397op/s 13022193.725op/s 0.67% 0.475 0.404 0.19% 1735.498op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 68.884µs 69.288µs ± 0.127µs 69.291µs ± 0.088µs 69.378µs 69.472µs 69.552µs 69.575µs 0.41% -0.292 0.028 0.18% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14373038.638op/s 14432588.819op/s ± 26551.464op/s 14431941.137op/s ± 18296.388op/s 14450281.639op/s 14479231.931op/s 14499415.490op/s 14517154.922op/s 0.59% 0.303 0.040 0.18% 1877.472op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.612µs 4.629µs ± 0.006µs 4.629µs ± 0.004µs 4.633µs 4.639µs 4.641µs 4.643µs 0.29% -0.156 0.002 0.12% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215397244.949op/s 216025634.576op/s ± 264510.704op/s 216017211.407op/s ± 178516.521op/s 216211224.465op/s 216466652.340op/s 216678019.342op/s 216840227.485op/s 0.38% 0.163 0.007 0.12% 18703.731op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 65.201µs 65.555µs ± 0.150µs 65.554µs ± 0.104µs 65.652µs 65.819µs 65.890µs 65.913µs 0.55% 0.078 -0.322 0.23% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15171532.018op/s 15254503.316op/s ± 34828.637op/s 15254676.837op/s ± 24230.596op/s 15279755.471op/s 15314253.895op/s 15327752.293op/s 15337280.327op/s 0.54% -0.067 -0.323 0.23% 2462.757op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 64.222µs 64.302µs ± 0.029µs 64.301µs ± 0.017µs 64.317µs 64.352µs 64.374µs 64.414µs 0.18% 0.400 0.857 0.04% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 15524576.948op/s 15551704.765op/s ± 6936.162op/s 15551778.600op/s ± 4059.930op/s 15555858.308op/s 15562884.544op/s 15565097.402op/s 15571009.894op/s 0.12% -0.396 0.850 0.04% 490.461op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.833µs 6.842µs ± 0.003µs 6.842µs ± 0.002µs 6.844µs 6.848µs 6.849µs 6.854µs 0.17% -0.159 1.016 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145909086.463op/s 146145943.218op/s ± 68602.149op/s 146150206.625op/s ± 34186.807op/s 146180093.926op/s 146271346.051op/s 146333262.503op/s 146354315.991op/s 0.14% 0.163 1.017 0.05% 4850.904op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.627µs; 4.628µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ throughput [216060520.046op/s; 216139352.623op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [96.401µs; 96.507µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10362399.426op/s; 10373164.380op/s] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [88.694µs; 88.811µs] or [-0.066%; +0.066%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11260425.134op/s; 11274642.097op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631 execution_time [4.626µs; 4.628µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number/37828224631 throughput [216072542.709op/s; 216157617.640op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number/378282246310005 execution_time [85.392µs; 85.465µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number/378282246310005 throughput [11700829.358op/s; 11710734.676op/s] or [-0.042%; +0.042%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [64.308µs; 64.330µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [15544972.588op/s; 15550144.511op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [146127585.163op/s; 146150584.350op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.629µs; 4.630µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ throughput [215966537.443op/s; 216035682.971op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [77.290µs; 77.330µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [12931563.476op/s; 12938366.505op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [69.270µs; 69.306µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [14428909.041op/s; 14436268.596op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.628µs; 4.630µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [215988975.936op/s; 216062293.215op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [65.534µs; 65.575µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15249676.402op/s; 15259330.230op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [64.298µs; 64.306µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [15550743.480op/s; 15552666.051op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146136435.620op/s; 146155450.816op/s] or [-0.007%; +0.007%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.036ms 9.080ms ± 0.018ms 9.079ms ± 0.010ms 9.089ms 9.110ms 9.121ms 9.183ms 1.15% 1.438 6.016 0.20% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.078ms; 9.083ms] or [-0.027%; +0.027%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.258µs 36.762µs ± 0.931µs 36.332µs ± 0.030µs 36.391µs 38.760µs 38.789µs 39.952µs 9.96% 1.739 1.175 2.53% 0.066µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [36.633µs; 36.891µs] or [-0.351%; +0.351%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 298.033ns 308.574ns ± 13.068ns 304.304ns ± 3.876ns 307.894ns 338.183ns 347.828ns 348.147ns 14.41% 1.743 1.736 4.22% 0.924ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [306.763ns; 310.385ns] or [-0.587%; +0.587%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9e24825 1733222533 julio/fix-builder-cmake-path
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.145µs 280.663µs ± 0.210µs 280.653µs ± 0.113µs 280.749µs 281.048µs 281.223µs 281.560µs 0.32% 0.808 2.115 0.07% 0.015µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3551638.606op/s 3562992.593op/s ± 2659.768op/s 3563117.963op/s ± 1428.960op/s 3564603.084op/s 3566917.468op/s 3568564.607op/s 3569581.404op/s 0.18% -0.800 2.093 0.07% 188.074op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.209µs 27.288µs ± 0.040µs 27.283µs ± 0.025µs 27.311µs 27.365µs 27.393µs 27.419µs 0.50% 0.675 0.307 0.15% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 36471521.696op/s 36645591.379op/s ± 54039.446op/s 36652401.535op/s ± 34046.785op/s 36682625.482op/s 36718765.413op/s 36738429.418op/s 36752641.596op/s 0.27% -0.667 0.292 0.15% 3821.166op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.610µs 16.958µs ± 0.114µs 16.994µs ± 0.028µs 17.019µs 17.051µs 17.076µs 17.100µs 0.62% -1.938 2.473 0.67% 0.008µs 1 200
normalization/normalize_name/normalize_name/good throughput 58479152.182op/s 58971618.245op/s ± 403079.929op/s 58842839.252op/s ± 97942.977op/s 58953268.353op/s 60004448.663op/s 60170067.459op/s 60202917.277op/s 2.31% 1.952 2.515 0.68% 28502.055op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [280.634µs; 280.692µs] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3562623.975op/s; 3563361.212op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.283µs; 27.294µs] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36638102.032op/s; 36653080.727op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.942µs; 16.974µs] or [-0.093%; +0.093%] None None None
normalization/normalize_name/normalize_name/good throughput [58915755.244op/s; 59027481.247op/s] or [-0.095%; +0.095%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (e9e4c06) to head (9e24825).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   70.55%   70.52%   -0.04%     
==========================================
  Files         297      297              
  Lines       43528    43533       +5     
==========================================
- Hits        30712    30701      -11     
- Misses      12816    12832      +16
Components Coverage Δ
crashtracker 44.89% <ø> (+0.02%) ⬆️
crashtracker-ffi 8.41% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 88.76% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.07% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (-0.11%) ⬇️
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.01% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 93.47% <ø> (ø)
trace-mini-agent 72.38% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.29% <ø> (ø)

@hoolioh hoolioh marked this pull request as ready for review December 2, 2024 14:51
@hoolioh hoolioh requested a review from a team as a code owner December 2, 2024 14:51
VianneyRuhlmann
VianneyRuhlmann reviewed Dec 3, 2024
View reviewed changes
builder/src/crashtracker.rs Outdated
@@ -22,11 +22,15 @@ pub struct CrashTracker {
impl CrashTracker {
fn gen_binaries(&self) -> Result<()> {
if arch::BUILD_CRASHTRACKER {
let mut datadog_root = project_root();
datadog_root.push(self.target_dir.as_ref());
println!("ROOT: {}", datadog_root.to_str().unwrap());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitt: Is it for logging or is it a debug print that was forgotten ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latter, thanks for noticing

@hoolioh hoolioh force-pushed the julio/fix-builder-cmake-path branch from ea72e53 to 9e24825 Compare December 3, 2024 10:42
@hoolioh hoolioh enabled auto-merge (squash) December 3, 2024 10:42
@hoolioh hoolioh merged commit 1776e5d into main Dec 3, 2024
33 checks passed
@hoolioh hoolioh deleted the julio/fix-builder-cmake-path branch December 3, 2024 11:05
hoolioh added a commit that referenced this pull request Dec 4, 2024
@hoolioh
Fix builder cmake target directory. (#776)
39fb938 
* Fix cmake target directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshnj ganeshnj ganeshnj approved these changes

@VianneyRuhlmann VianneyRuhlmann VianneyRuhlmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoolioh @codecov-commenter @ganeshnj @VianneyRuhlmann