Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telemetry] Add missing origin field #747

Merged
merged 4 commits into from
Dec 2, 2024
Merged

[telemetry] Add missing origin field #747

merged 4 commits into from
Dec 2, 2024

Conversation

danielsn
Copy link
Contributor

What does this PR do?

Adds the origin field, defined in the backend but not currently implemented in libdatadog.

Motivation

#727 We'd like to use this field in the crashtracker.

Additional Notes

  • I put placeholder values in for the different uses. LMK if I should change them?
  • The ddcommon request builder currently just sets "unknown". I could plumb through an option to set a value, but this might be a breaking change. Thoughts?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested review from a team as code owners November 19, 2024 15:24
@pr-commenter
Copy link

pr-commenter bot commented Nov 19, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-12-02 18:58:43

Comparing candidate commit 5272418 in PR branch dsn/telemetry-origin with baseline commit 1c1fc18 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.124ms 9.163ms ± 0.016ms 9.163ms ± 0.008ms 9.171ms 9.186ms 9.200ms 9.276ms 1.24% 1.991 12.927 0.17% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.161ms; 9.165ms] or [-0.024%; +0.024%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 59.388ms 59.666ms ± 0.178ms 59.642ms ± 0.082ms 59.717ms 60.007ms 60.290ms 60.736ms 1.83% 2.098 7.405 0.30% 0.013ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [59.642ms; 59.691ms] or [-0.041%; +0.041%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.212µs 280.760µs ± 0.256µs 280.747µs ± 0.135µs 280.874µs 281.073µs 281.467µs 282.808µs 0.73% 2.848 20.001 0.09% 0.018µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3535973.039op/s 3561764.599op/s ± 3236.622op/s 3561924.550op/s ± 1709.726op/s 3563747.095op/s 3565607.563op/s 3567962.213op/s 3568726.096op/s 0.19% -2.810 19.632 0.09% 228.864op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.037µs 27.219µs ± 0.113µs 27.183µs ± 0.072µs 27.294µs 27.430µs 27.467µs 27.616µs 1.59% 0.746 -0.206 0.41% 0.008µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 36210629.993op/s 36739475.203op/s ± 151744.157op/s 36787743.421op/s ± 97232.540op/s 36862932.822op/s 36927590.043op/s 36946398.342op/s 36986260.837op/s 0.54% -0.731 -0.246 0.41% 10729.932op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.552µs 16.627µs ± 0.036µs 16.624µs ± 0.021µs 16.646µs 16.689µs 16.711µs 16.830µs 1.24% 1.101 4.128 0.22% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 59418249.630op/s 60143190.738op/s ± 129710.846op/s 60153638.564op/s ± 75758.222op/s 60218461.785op/s 60334749.567op/s 60374702.911op/s 60416439.675op/s 0.44% -1.070 3.949 0.22% 9171.942op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [280.724µs; 280.795µs] or [-0.013%; +0.013%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3561316.034op/s; 3562213.164op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.204µs; 27.235µs] or [-0.057%; +0.057%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36718444.923op/s; 36760505.484op/s] or [-0.057%; +0.057%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.622µs; 16.632µs] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/good throughput [60125214.062op/s; 60161167.414op/s] or [-0.030%; +0.030%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 508.752µs 509.868µs ± 0.988µs 509.733µs ± 0.293µs 510.062µs 510.690µs 511.935µs 521.529µs 2.31% 8.532 95.899 0.19% 0.070µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1917437.834op/s 1961300.466op/s ± 3737.858op/s 1961811.380op/s ± 1127.987op/s 1962835.386op/s 1963892.712op/s 1965108.255op/s 1965596.057op/s 0.19% -8.387 93.515 0.19% 264.306op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 465.179µs 466.440µs ± 0.446µs 466.422µs ± 0.272µs 466.715µs 467.124µs 467.438µs 469.068µs 0.57% 0.961 5.079 0.10% 0.032µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2131885.147op/s 2143900.477op/s ± 2050.216op/s 2143982.532op/s ± 1251.627op/s 2145065.653op/s 2146890.169op/s 2147728.133op/s 2149710.841op/s 0.27% -0.944 4.980 0.10% 144.972op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.342µs 176.136µs ± 0.264µs 176.148µs ± 0.147µs 176.275µs 176.533µs 176.746µs 177.470µs 0.75% 0.395 2.908 0.15% 0.019µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5634769.109op/s 5677458.907op/s ± 8492.142op/s 5677032.906op/s ± 4726.214op/s 5682190.643op/s 5692324.138op/s 5695905.596op/s 5703136.976op/s 0.46% -0.374 2.834 0.15% 600.485op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.978µs 45.263µs ± 0.157µs 45.206µs ± 0.116µs 45.405µs 45.523µs 45.558µs 45.586µs 0.84% 0.259 -1.254 0.34% 0.011µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21936484.387op/s 22093485.789op/s ± 76332.836op/s 22120825.520op/s ± 56973.532op/s 22160124.983op/s 22198812.184op/s 22216271.448op/s 22233070.699op/s 0.51% -0.252 -1.258 0.34% 5397.547op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 41.816µs 42.034µs ± 0.210µs 41.959µs ± 0.090µs 42.097µs 42.410µs 42.546µs 43.336µs 3.28% 1.964 6.504 0.50% 0.015µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 23075607.227op/s 23790852.495op/s ± 117588.653op/s 23832566.905op/s ± 51491.674op/s 23876237.013op/s 23897671.832op/s 23908217.231op/s 23914266.316op/s 0.34% -1.897 5.943 0.49% 8314.773op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [509.731µs; 510.005µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1960782.435op/s; 1961818.497op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [466.378µs; 466.502µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2143616.337op/s; 2144184.617op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.099µs; 176.172µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5676281.978op/s; 5678635.836op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.241µs; 45.284µs] or [-0.048%; +0.048%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22082906.792op/s; 22104064.786op/s] or [-0.048%; +0.048%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [42.005µs; 42.063µs] or [-0.069%; +0.069%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [23774555.839op/s; 23807149.152op/s] or [-0.068%; +0.068%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.296µs 38.697µs ± 0.676µs 38.388µs ± 0.038µs 38.445µs 40.090µs 40.174µs 41.884µs 9.11% 1.897 2.520 1.74% 0.048µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.603µs; 38.791µs] or [-0.242%; +0.242%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 296.117ns 307.929ns ± 12.365ns 303.940ns ± 4.639ns 309.169ns 338.169ns 347.168ns 348.247ns 14.58% 1.827 2.456 4.01% 0.874ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [306.216ns; 309.643ns] or [-0.557%; +0.557%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.501µs 150.373µs ± 0.299µs 150.350µs ± 0.159µs 150.529µs 150.852µs 151.504µs 151.897µs 1.03% 1.127 4.938 0.20% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.332µs; 150.415µs] or [-0.028%; +0.028%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.619µs 4.631µs ± 0.006µs 4.631µs ± 0.002µs 4.633µs 4.637µs 4.639µs 4.700µs 1.49% 8.144 94.558 0.13% 0.000µs 1 200
credit_card/is_card_number/ throughput 212747465.507op/s 215913555.855op/s ± 270047.820op/s 215920609.623op/s ± 90252.198op/s 216019296.658op/s 216173356.654op/s 216304410.593op/s 216499639.050op/s 0.27% -8.030 92.832 0.12% 19095.264op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 91.377µs 92.372µs ± 0.479µs 92.386µs ± 0.125µs 92.483µs 92.616µs 92.789µs 98.263µs 6.36% 9.201 112.796 0.52% 0.034µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10176752.451op/s 10826081.777op/s ± 53663.407op/s 10824100.330op/s ± 14645.053op/s 10840112.984op/s 10885786.224op/s 10908595.424op/s 10943715.767op/s 1.11% -8.734 105.682 0.49% 3794.576op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 87.088µs 87.681µs ± 0.455µs 87.663µs ± 0.105µs 87.743µs 88.078µs 88.898µs 92.758µs 5.81% 7.574 77.937 0.52% 0.032µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10780709.954op/s 11405258.441op/s ± 57010.745op/s 11407328.574op/s ± 13640.037op/s 11423566.070op/s 11458123.444op/s 11480090.221op/s 11482598.123op/s 0.66% -7.231 72.641 0.50% 4031.268op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.618µs 4.631µs ± 0.006µs 4.631µs ± 0.003µs 4.633µs 4.637µs 4.640µs 4.706µs 1.62% 7.799 88.523 0.14% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 212495168.440op/s 215931470.890op/s ± 297991.590op/s 215945905.551op/s ± 125496.781op/s 216071027.953op/s 216205207.930op/s 216333582.060op/s 216537923.510op/s 0.27% -7.675 86.657 0.14% 21071.187op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 83.971µs 84.689µs ± 0.265µs 84.704µs ± 0.172µs 84.846µs 85.022µs 85.455µs 86.029µs 1.56% 0.620 3.365 0.31% 0.019µs 1 200
credit_card/is_card_number/378282246310005 throughput 11623946.038op/s 11808038.517op/s ± 36875.150op/s 11805793.715op/s ± 23880.131op/s 11831838.590op/s 11865925.345op/s 11899490.055op/s 11908844.457op/s 0.87% -0.574 3.194 0.31% 2607.467op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.597µs 58.680µs ± 0.036µs 58.676µs ± 0.020µs 58.696µs 58.744µs 58.769µs 58.880µs 0.35% 1.589 6.238 0.06% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16983785.054op/s 17041587.411op/s ± 10396.714op/s 17042686.298op/s ± 5763.800op/s 17048464.624op/s 17053666.382op/s 17061170.219op/s 17065636.634op/s 0.13% -1.578 6.178 0.06% 735.159op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.554µs 6.565µs ± 0.004µs 6.565µs ± 0.002µs 6.567µs 6.571µs 6.572µs 6.577µs 0.18% -0.332 0.574 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 152045050.859op/s 152321053.900op/s ± 88799.759op/s 152313258.880op/s ± 49832.555op/s 152370619.995op/s 152479152.375op/s 152555589.048op/s 152583882.313op/s 0.18% 0.337 0.576 0.06% 6279.091op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.622µs 4.631µs ± 0.005µs 4.631µs ± 0.002µs 4.634µs 4.639µs 4.649µs 4.662µs 0.68% 1.959 8.189 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 214494524.627op/s 215919579.555op/s ± 232536.263op/s 215953502.522op/s ± 106577.622op/s 216042523.256op/s 216223422.683op/s 216275148.569op/s 216357357.819op/s 0.19% -1.938 8.053 0.11% 16442.797op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 69.044µs 69.921µs ± 0.396µs 69.905µs ± 0.308µs 70.220µs 70.598µs 70.748µs 70.829µs 1.32% 0.211 -0.782 0.57% 0.028µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14118496.840op/s 14302353.256op/s ± 80982.968op/s 14305194.225op/s ± 63248.415op/s 14366324.294op/s 14417341.923op/s 14447351.575op/s 14483448.811op/s 1.25% -0.191 -0.789 0.56% 5726.361op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 64.109µs 64.434µs ± 0.206µs 64.404µs ± 0.117µs 64.545µs 64.714µs 65.228µs 65.610µs 1.87% 1.677 6.586 0.32% 0.015µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15241662.420op/s 15519857.100op/s ± 49296.185op/s 15526926.425op/s ± 28152.064op/s 15552221.249op/s 15586547.931op/s 15597630.627op/s 15598388.686op/s 0.46% -1.623 6.259 0.32% 3485.767op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.623µs 4.631µs ± 0.003µs 4.631µs ± 0.002µs 4.633µs 4.635µs 4.638µs 4.641µs 0.23% -0.009 0.235 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215448623.882op/s 215956071.573op/s ± 149945.976op/s 215952684.774op/s ± 101809.991op/s 216062587.938op/s 216219565.565op/s 216304260.280op/s 216321302.030op/s 0.17% 0.014 0.232 0.07% 10602.782op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.245µs 62.499µs ± 0.095µs 62.483µs ± 0.052µs 62.553µs 62.647µs 62.717µs 63.084µs 0.96% 1.342 6.371 0.15% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15851922.437op/s 16000187.506op/s ± 24198.803op/s 16004466.847op/s ± 13213.742op/s 16015949.884op/s 16032974.785op/s 16048448.327op/s 16065653.901op/s 0.38% -1.312 6.180 0.15% 1711.114op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.588µs 58.681µs ± 0.044µs 58.677µs ± 0.020µs 58.695µs 58.753µs 58.824µs 58.961µs 0.48% 1.965 8.780 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16960410.732op/s 17041416.810op/s ± 12652.780op/s 17042411.136op/s ± 5791.055op/s 17048523.688op/s 17056689.909op/s 17064612.091op/s 17068261.568op/s 0.15% -1.950 8.671 0.07% 894.687op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.554µs 6.566µs ± 0.004µs 6.565µs ± 0.002µs 6.568µs 6.572µs 6.577µs 6.588µs 0.34% 1.067 4.357 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 151795976.639op/s 152308363.017op/s ± 95259.452op/s 152316800.546op/s ± 45807.827op/s 152356002.258op/s 152429334.028op/s 152518525.494op/s 152577049.406op/s 0.17% -1.057 4.315 0.06% 6735.860op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.631µs; 4.632µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ throughput [215876129.824op/s; 215950981.885op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [92.305µs; 92.438µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10818644.545op/s; 10833519.009op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [87.618µs; 87.744µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11397357.300op/s; 11413159.582op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number/37828224631 execution_time [4.630µs; 4.632µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/37828224631 throughput [215890172.121op/s; 215972769.658op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/378282246310005 execution_time [84.652µs; 84.726µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/378282246310005 throughput [11802927.976op/s; 11813149.058op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.675µs; 58.685µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [17040146.526op/s; 17043028.295op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.565µs; 6.566µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [152308747.107op/s; 152333360.693op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.631µs; 4.632µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ throughput [215887352.266op/s; 215951806.845op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [69.866µs; 69.976µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14291129.795op/s; 14313576.716op/s] or [-0.078%; +0.078%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [64.406µs; 64.463µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15513025.123op/s; 15526689.077op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.630µs; 4.631µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [215935290.503op/s; 215976852.643op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.486µs; 62.513µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15996833.784op/s; 16003541.227op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.675µs; 58.687µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [17039663.256op/s; 17043170.363op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.565µs; 6.566µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [152295160.973op/s; 152321565.061op/s] or [-0.009%; +0.009%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.616µs 2.674µs ± 0.020µs 2.670µs ± 0.008µs 2.684µs 2.717µs 2.725µs 2.741µs 2.65% 0.026 1.794 0.76% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.672µs; 2.677µs] or [-0.106%; +0.106%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.393µs 3.271µs ± 1.453µs 3.115µs ± 0.023µs 3.135µs 3.168µs 14.309µs 15.341µs 392.54% 7.608 57.895 44.32% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.069µs; 3.472µs] or [-6.158%; +6.158%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.647µs 25.108µs ± 14.715µs 19.031µs ± 0.073µs 20.060µs 47.203µs 58.508µs 166.178µs 773.19% 5.244 42.129 58.46% 1.040µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.069µs; 27.148µs] or [-8.122%; +8.122%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 5272418 1733165301 dsn/telemetry-origin
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 76.744µs 76.931µs ± 0.138µs 76.908µs ± 0.039µs 76.963µs 77.059µs 77.144µs 78.576µs 2.17% 8.713 100.555 0.18% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [76.912µs; 76.950µs] or [-0.025%; +0.025%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.55%. Comparing base (1c1fc18) to head (5272418).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   70.57%   70.55%   -0.03%     
==========================================
  Files         297      297              
  Lines       43515    43518       +3     
==========================================
- Hits        30711    30704       -7     
- Misses      12804    12814      +10
Components Coverage Δ
crashtracker 44.89% <100.00%> (+0.06%) ⬆️
crashtracker-ffi 8.41% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 89.09% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.07% <100.00%> (+0.01%) ⬆️
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.82% <ø> (+0.06%) ⬆️
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.01% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 93.47% <ø> (ø)
trace-mini-agent 72.38% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.29% <ø> (ø)

@danielsn danielsn enabled auto-merge (squash) December 2, 2024 18:48
@danielsn danielsn merged commit 41059dd into main Dec 2, 2024
32 checks passed
@danielsn danielsn deleted the dsn/telemetry-origin branch December 2, 2024 19:11
morrisonlevi pushed a commit that referenced this pull request Dec 2, 2024
@danielsn @morrisonlevi
[telemetry] Add missing origin field (#747)
d8b4f36
hoolioh pushed a commit that referenced this pull request Dec 4, 2024
@danielsn @hoolioh
[telemetry] Add missing origin field (#747)
9740752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchda sanchda sanchda approved these changes

@ekump ekump ekump approved these changes

@nsavoire nsavoire nsavoire approved these changes

@paullegranddc paullegranddc paullegranddc approved these changes

@yahya-mouman yahya-mouman Awaiting requested review from yahya-mouman yahya-mouman is a code owner automatically assigned from DataDog/libdatadog-telemetry

Assignees
No one assigned
Labels
crashtracker telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danielsn @codecov-commenter @sanchda @ekump @nsavoire @paullegranddc