-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix crypto provider issues in ddcommon #705
Conversation
5986983
to
3068cb3
Compare
…/libdatadog into sanchda/ddcommon_ensure_provider
BenchmarksComparisonBenchmark execution time: 2024-11-01 17:30:26 Comparing candidate commit e4e74e9 in PR branch Found 4 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて
scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 70.52% 70.54% +0.01%
==========================================
Files 281 281
Lines 41838 41840 +2
==========================================
+ Hits 29508 29516 +8
+ Misses 12330 12324 -6
|
What does this PR do?
Adds a lazy_static that forces the initialization of a process-wide crypto provider at the moment of need
Motivation
I've seen some panics in downstream issues, and started seeing one now when trying to prepare the v14.0.0 release
Other comments
Courtesy of @duncanpharvey, note the third bullet in the rustls changelog from 0.23. It looks like our tokio-rustls and hyper-rustls dependencies bump this rustls version where we use it ddcommon, so this may explain part of what we see.