Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix crypto provider issues in ddcommon #705

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Nov 1, 2024

What does this PR do?

Adds a lazy_static that forces the initialization of a process-wide crypto provider at the moment of need

Motivation

I've seen some panics in downstream issues, and started seeing one now when trying to prepare the v14.0.0 release

Other comments

Courtesy of @duncanpharvey, note the third bullet in the rustls changelog from 0.23. It looks like our tokio-rustls and hyper-rustls dependencies bump this rustls version where we use it ddcommon, so this may explain part of what we see.

@sanchda sanchda requested a review from a team as a code owner November 1, 2024 16:47
@github-actions github-actions bot added the common label Nov 1, 2024
@sanchda sanchda requested a review from a team as a code owner November 1, 2024 16:52
@sanchda sanchda force-pushed the sanchda/ddcommon_ensure_provider branch from 5986983 to 3068cb3 Compare November 1, 2024 17:08
@pr-commenter
Copy link

pr-commenter bot commented Nov 1, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-11-01 17:30:26

Comparing candidate commit e4e74e9 in PR branch sanchda/ddcommon_ensure_provider with baseline commit 66016ac in branch main.

Found 4 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟩 execution_time [-88.091ns; -72.092ns] or [-6.924%; -5.667%]

scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて

  • 🟩 execution_time [-21.673µs; -21.385µs] or [-4.481%; -4.422%]
  • 🟩 throughput [+95692.384op/s; +96950.791op/s] or [+4.628%; +4.689%]

scenario:tags/replace_trace_tags

  • 🟩 execution_time [-156.734ns; -151.479ns] or [-5.473%; -5.289%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.741µs 25.280µs ± 11.469µs 19.862µs ± 0.443µs 27.789µs 46.044µs 50.711µs 102.609µs 416.62% 3.139 14.733 45.25% 0.811µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.691µs; 26.870µs] or [-6.288%; +6.288%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 190.113µs 192.868µs ± 0.955µs 192.877µs ± 0.617µs 193.526µs 194.313µs 194.671µs 195.347µs 1.28% -0.361 0.152 0.49% 0.068µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5119084.040op/s 5185026.445op/s ± 25716.731op/s 5184651.714op/s ± 16589.916op/s 5200779.337op/s 5227648.748op/s 5254713.093op/s 5260020.096op/s 1.45% 0.391 0.189 0.49% 1818.448op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.147µs 18.191µs ± 0.029µs 18.193µs ± 0.024µs 18.210µs 18.249µs 18.271µs 18.286µs 0.51% 0.792 0.100 0.16% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54685175.590op/s 54972358.452op/s ± 87141.292op/s 54965094.918op/s ± 73391.897op/s 55048199.834op/s 55066953.016op/s 55079428.387op/s 55104523.474op/s 0.25% -0.785 0.079 0.16% 6161.820op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.308µs 11.372µs ± 0.040µs 11.372µs ± 0.026µs 11.390µs 11.432µs 11.471µs 11.621µs 2.19% 1.499 6.537 0.35% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 86052262.407op/s 87936209.620op/s ± 306083.456op/s 87938516.703op/s ± 198183.862op/s 88213120.179op/s 88309315.092op/s 88399956.269op/s 88434907.795op/s 0.56% -1.434 6.068 0.35% 21643.369op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [192.735µs; 193.000µs] or [-0.069%; +0.069%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5181462.353op/s; 5188590.536op/s] or [-0.069%; +0.069%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.187µs; 18.195µs] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54960281.507op/s; 54984435.397op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.367µs; 11.378µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/good throughput [87893789.397op/s; 87978629.843op/s] or [-0.048%; +0.048%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 143.493µs 144.425µs ± 0.645µs 144.350µs ± 0.227µs 144.586µs 145.150µs 145.771µs 151.673µs 5.07% 7.328 78.473 0.45% 0.046µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [144.336µs; 144.515µs] or [-0.062%; +0.062%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.132µs 1.192µs ± 0.023µs 1.197µs ± 0.015µs 1.212µs 1.215µs 1.217µs 1.218µs 1.72% -1.030 0.219 1.95% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.189µs; 1.195µs] or [-0.272%; +0.272%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.600µs 4.615µs ± 0.005µs 4.615µs ± 0.002µs 4.617µs 4.619µs 4.621µs 4.662µs 1.02% 6.693 59.348 0.10% 0.000µs 1 200
credit_card/is_card_number/ throughput 214504734.984op/s 216669082.741op/s ± 226152.734op/s 216689445.045op/s ± 71234.569op/s 216755673.465op/s 216831112.013op/s 216914762.877op/s 217379533.837op/s 0.32% -6.641 58.781 0.10% 15991.413op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.348µs 91.222µs ± 0.501µs 91.159µs ± 0.273µs 91.438µs 91.954µs 93.087µs 94.511µs 3.68% 2.224 10.363 0.55% 0.035µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10580785.063op/s 10962536.251op/s ± 59521.031op/s 10969875.625op/s ± 32798.426op/s 10999845.986op/s 11038171.488op/s 11055070.748op/s 11068312.518op/s 0.90% -2.106 9.488 0.54% 4208.772op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 82.737µs 83.636µs ± 0.583µs 83.580µs ± 0.377µs 83.922µs 84.605µs 85.406µs 86.989µs 4.08% 1.558 5.266 0.69% 0.041µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11495759.214op/s 11957104.890op/s ± 82423.101op/s 11964619.424op/s ± 54211.079op/s 12021677.188op/s 12060654.177op/s 12074554.156op/s 12086454.408op/s 1.02% -1.461 4.654 0.69% 5828.193op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.602µs 4.615µs ± 0.002µs 4.614µs ± 0.001µs 4.616µs 4.619µs 4.620µs 4.624µs 0.21% -0.017 4.098 0.05% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 216256069.540op/s 216706020.124op/s ± 111763.302op/s 216718843.707op/s ± 63471.676op/s 216772559.197op/s 216847436.751op/s 216898991.639op/s 217293602.664op/s 0.27% 0.027 4.123 0.05% 7902.859op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 79.837µs 80.588µs ± 0.259µs 80.611µs ± 0.137µs 80.721µs 80.990µs 81.103µs 81.324µs 0.88% -0.313 0.332 0.32% 0.018µs 1 200
credit_card/is_card_number/378282246310005 throughput 12296486.992op/s 12408941.830op/s ± 39994.026op/s 12405238.862op/s ± 20995.621op/s 12430823.712op/s 12482041.775op/s 12517328.682op/s 12525510.708op/s 0.97% 0.335 0.341 0.32% 2828.005op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.261µs 59.579µs ± 0.233µs 59.583µs ± 0.179µs 59.745µs 60.051µs 60.097µs 60.107µs 0.88% 0.439 -0.672 0.39% 0.016µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16636883.674op/s 16784662.361op/s ± 65589.742op/s 16783262.053op/s ± 50281.821op/s 16845533.913op/s 16870416.444op/s 16872381.251op/s 16874583.974op/s 0.54% -0.426 -0.690 0.39% 4637.895op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 7.219µs 7.223µs ± 0.007µs 7.223µs ± 0.002µs 7.224µs 7.227µs 7.233µs 7.307µs 1.17% 9.787 113.230 0.09% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 136850892.011op/s 138439548.557op/s ± 130002.778op/s 138445251.825op/s ± 35905.417op/s 138490004.484op/s 138517056.298op/s 138523525.312op/s 138528495.311op/s 0.06% -9.732 112.249 0.09% 9192.585op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.601µs 4.615µs ± 0.002µs 4.614µs ± 0.001µs 4.616µs 4.618µs 4.620µs 4.624µs 0.20% -0.317 5.054 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 216284495.855op/s 216707252.407op/s ± 110120.204op/s 216713403.725op/s ± 70014.537op/s 216777649.756op/s 216852052.322op/s 216886988.035op/s 217333527.232op/s 0.29% 0.328 5.095 0.05% 7786.674op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.864µs 74.442µs ± 0.162µs 74.469µs ± 0.095µs 74.533µs 74.695µs 74.769µs 74.807µs 0.45% -0.553 0.750 0.22% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13367776.648op/s 13433274.021op/s ± 29327.112op/s 13428441.183op/s ± 17171.984op/s 13448908.615op/s 13483434.522op/s 13509133.687op/s 13538465.488op/s 0.82% 0.569 0.777 0.22% 2073.740op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 66.359µs 66.832µs ± 0.237µs 66.816µs ± 0.174µs 66.989µs 67.265µs 67.420µs 67.503µs 1.03% 0.474 -0.204 0.35% 0.017µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14814195.911op/s 14963104.208op/s ± 52873.348op/s 14966457.928op/s ± 38885.011op/s 15004621.469op/s 15039988.472op/s 15044168.027op/s 15069536.871op/s 0.69% -0.458 -0.227 0.35% 3738.710op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.602µs 4.615µs ± 0.006µs 4.615µs ± 0.002µs 4.616µs 4.619µs 4.621µs 4.687µs 1.55% 10.460 132.041 0.12% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 213375830.030op/s 216675717.745op/s ± 258883.224op/s 216685091.897op/s ± 75242.853op/s 216771754.643op/s 216844333.824op/s 216880200.223op/s 217289270.250op/s 0.28% -10.371 130.574 0.12% 18305.808op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.363µs 62.670µs ± 0.181µs 62.652µs ± 0.133µs 62.774µs 63.026µs 63.202µs 63.333µs 1.09% 0.987 1.072 0.29% 0.013µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15789567.694op/s 15956825.634op/s ± 45839.346op/s 15961255.650op/s ± 33817.171op/s 15997536.380op/s 16007050.146op/s 16028817.137op/s 16035136.190op/s 0.46% -0.969 1.013 0.29% 3241.331op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.270µs 59.519µs ± 0.200µs 59.490µs ± 0.158µs 59.638µs 59.866µs 60.004µs 60.091µs 1.01% 0.560 -0.522 0.33% 0.014µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16641369.815op/s 16801528.438op/s ± 56240.122op/s 16809618.935op/s ± 44577.858op/s 16855761.639op/s 16870420.754op/s 16871789.339op/s 16872043.025op/s 0.37% -0.548 -0.546 0.33% 3976.777op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 7.218µs 7.223µs ± 0.002µs 7.223µs ± 0.002µs 7.224µs 7.226µs 7.228µs 7.229µs 0.09% 0.194 -0.595 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 138328735.193op/s 138451693.339op/s ± 42490.687op/s 138448254.967op/s ± 32979.924op/s 138490084.110op/s 138512463.353op/s 138521409.735op/s 138535880.793op/s 0.06% -0.192 -0.597 0.03% 3004.545op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.615µs; 4.616µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/ throughput [216637740.148op/s; 216700425.335op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [91.153µs; 91.292µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10954287.208op/s; 10970785.293op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [83.556µs; 83.717µs] or [-0.097%; +0.097%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11945681.840op/s; 11968527.939op/s] or [-0.096%; +0.096%] None None None
credit_card/is_card_number/37828224631 execution_time [4.614µs; 4.615µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631 throughput [216690530.806op/s; 216721509.443op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.552µs; 80.624µs] or [-0.045%; +0.045%] None None None
credit_card/is_card_number/378282246310005 throughput [12403399.042op/s; 12414484.617op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.547µs; 59.611µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16775572.254op/s; 16793752.469op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/x371413321323331 execution_time [7.222µs; 7.224µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/x371413321323331 throughput [138421531.422op/s; 138457565.692op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.614µs; 4.615µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ throughput [216691990.805op/s; 216722514.008op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [74.420µs; 74.465µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13429209.566op/s; 13437338.477op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.799µs; 66.865µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [14955776.471op/s; 14970431.946op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.614µs; 4.616µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216639839.020op/s; 216711596.470op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.645µs; 62.695µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15950472.741op/s; 15963178.526op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.491µs; 59.547µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16793734.098op/s; 16809322.778op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [7.222µs; 7.223µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [138445804.539op/s; 138457582.140op/s] or [-0.004%; +0.004%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.396µs 3.171µs ± 1.250µs 3.040µs ± 0.031µs 3.065µs 3.115µs 10.008µs 14.792µs 386.54% 7.940 65.503 39.32% 0.088µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.998µs; 3.344µs] or [-5.463%; +5.463%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.797µs 38.493µs ± 1.306µs 37.889µs ± 0.048µs 37.977µs 41.295µs 41.338µs 42.372µs 11.83% 1.715 1.000 3.38% 0.092µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.312µs; 38.674µs] or [-0.470%; +0.470%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.681µs 2.710µs ± 0.017µs 2.706µs ± 0.008µs 2.716µs 2.756µs 2.760µs 2.760µs 2.02% 1.530 2.176 0.63% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.707µs; 2.712µs] or [-0.087%; +0.087%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 73.263µs 73.410µs ± 0.207µs 73.391µs ± 0.029µs 73.420µs 73.475µs 73.683µs 76.206µs 3.84% 12.447 165.151 0.28% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [73.381µs; 73.438µs] or [-0.039%; +0.039%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.157ms 9.187ms ± 0.015ms 9.188ms ± 0.008ms 9.195ms 9.213ms 9.231ms 9.248ms 0.66% 0.561 1.187 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.185ms; 9.189ms] or [-0.023%; +0.023%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 623.461µs 624.541µs ± 0.454µs 624.552µs ± 0.284µs 624.817µs 625.238µs 625.670µs 626.229µs 0.27% 0.361 0.580 0.07% 0.032µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1596859.206op/s 1601177.285op/s ± 1163.049op/s 1601147.703op/s ± 727.816op/s 1601940.178op/s 1602978.416op/s 1603638.037op/s 1603950.668op/s 0.18% -0.356 0.571 0.07% 82.240op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 461.080µs 462.115µs ± 0.481µs 462.103µs ± 0.309µs 462.423µs 462.936µs 463.284µs 463.566µs 0.32% 0.222 -0.024 0.10% 0.034µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2157190.375op/s 2163964.495op/s ± 2252.511op/s 2164021.312op/s ± 1446.531op/s 2165443.965op/s 2167599.031op/s 2168453.748op/s 2168820.534op/s 0.22% -0.216 -0.030 0.10% 159.277op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 178.200µs 178.375µs ± 0.092µs 178.370µs ± 0.050µs 178.412µs 178.562µs 178.639µs 178.687µs 0.18% 0.759 0.773 0.05% 0.006µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5596381.080op/s 5606156.362op/s ± 2875.698op/s 5606313.584op/s ± 1568.799op/s 5608276.777op/s 5610266.064op/s 5610788.393op/s 5611659.221op/s 0.10% -0.756 0.766 0.05% 203.343op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.613µs 46.799µs ± 0.075µs 46.789µs ± 0.048µs 46.842µs 46.922µs 47.007µs 47.135µs 0.74% 0.900 1.863 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21215497.545op/s 21368151.861op/s ± 34162.443op/s 21372606.386op/s ± 22151.269op/s 21393586.575op/s 21412318.740op/s 21427510.734op/s 21453187.168op/s 0.38% -0.886 1.812 0.16% 2415.650op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.452µs 48.709µs ± 0.112µs 48.704µs ± 0.070µs 48.776µs 48.900µs 48.948µs 49.027µs 0.66% 0.166 -0.273 0.23% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20396998.937op/s 20530200.132op/s ± 47126.902op/s 20532372.111op/s ± 29435.065op/s 20560097.486op/s 20606323.717op/s 20624847.967op/s 20638935.050op/s 0.52% -0.154 -0.278 0.23% 3332.375op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [624.478µs; 624.604µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1601016.097op/s; 1601338.472op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [462.049µs; 462.182µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2163652.318op/s; 2164276.671op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [178.363µs; 178.388µs] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5605757.818op/s; 5606554.906op/s] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.788µs; 46.809µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21363417.275op/s; 21372886.447op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.693µs; 48.724µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20523668.796op/s; 20536731.467op/s] or [-0.032%; +0.032%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e4e74e9 1730481665 sanchda/ddcommon_ensure_provider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 258.077ns 268.713ns ± 13.812ns 262.257ns ± 2.606ns 271.751ns 302.152ns 311.533ns 316.308ns 20.61% 1.857 2.461 5.13% 0.977ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [266.798ns; 270.627ns] or [-0.712%; +0.712%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (66016ac) to head (e4e74e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   70.52%   70.54%   +0.01%     
==========================================
  Files         281      281              
  Lines       41838    41840       +2     
==========================================
+ Hits        29508    29516       +8     
+ Misses      12330    12324       -6     
Components Coverage Δ
crashtracker 19.20% <ø> (+0.04%) ⬆️
crashtracker-ffi 9.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.86% <ø> (-0.07%) ⬇️
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.76% <100.00%> (+0.01%) ⬆️
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.22% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.65% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.13% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.14% <ø> (ø)

@sanchda sanchda merged commit 7620299 into main Nov 1, 2024
32 checks passed
@sanchda sanchda deleted the sanchda/ddcommon_ensure_provider branch November 1, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants