Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ddcommon): warning on unused import #699

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Conversation

morrisonlevi
Copy link
Contributor

What does this PR do?

This fixes the following warning:

warning: unused import: `rustls::pki_types::CertificateDer`
  --> ddcommon/src/connector/mod.rs:14:5
   |
14 | use rustls::pki_types::CertificateDer;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Motivation

I want main to not have warnings.

How to test the change?

Existing tests should work fine for both use_webpki_roots and not(use_webpki_roots).

@morrisonlevi morrisonlevi requested a review from a team as a code owner October 30, 2024 16:13
@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-11-01 16:49:58

Comparing candidate commit c18b159 in PR branch levi/ddcommon-warning with baseline commit 4f324e7 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:redis/obfuscate_redis_string

  • 🟩 execution_time [-1.239µs; -0.896µs] or [-3.188%; -2.305%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.797µs 23.431µs ± 9.975µs 18.601µs ± 0.339µs 23.117µs 37.612µs 43.515µs 93.353µs 401.87% 3.030 14.487 42.47% 0.705µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.048µs; 24.813µs] or [-5.900%; +5.900%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 189.524µs 192.767µs ± 1.188µs 193.013µs ± 0.675µs 193.618µs 194.387µs 194.756µs 195.107µs 1.08% -0.716 -0.130 0.61% 0.084µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5125389.968op/s 5187797.114op/s ± 32111.671op/s 5180986.874op/s ± 18127.653op/s 5204604.359op/s 5252726.596op/s 5270622.111op/s 5276370.013op/s 1.84% 0.741 -0.092 0.62% 2270.638op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.145µs 18.180µs ± 0.029µs 18.185µs ± 0.025µs 18.197µs 18.230µs 18.284µs 18.306µs 0.67% 1.232 2.453 0.16% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54626089.050op/s 55004675.635op/s ± 86731.999op/s 54990453.639op/s ± 76756.358op/s 55078301.042op/s 55100078.436op/s 55107105.914op/s 55111935.611op/s 0.22% -1.218 2.389 0.16% 6132.878op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.332µs 11.379µs ± 0.029µs 11.375µs ± 0.014µs 11.387µs 11.440µs 11.466µs 11.518µs 1.27% 1.520 3.539 0.25% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 86817389.794op/s 87884240.208op/s ± 221556.101op/s 87915831.603op/s ± 105074.936op/s 88025217.871op/s 88156149.192op/s 88222803.662op/s 88247318.626op/s 0.38% -1.495 3.428 0.25% 15666.382op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [192.603µs; 192.932µs] or [-0.085%; +0.085%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5183346.745op/s; 5192247.482op/s] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.176µs; 18.184µs] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54992655.414op/s; 55016695.856op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.375µs; 11.383µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/good throughput [87853534.663op/s; 87914945.752op/s] or [-0.035%; +0.035%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 144.013µs 144.705µs ± 0.526µs 144.658µs ± 0.147µs 144.798µs 145.268µs 146.324µs 150.341µs 3.93% 6.596 65.381 0.36% 0.037µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [144.632µs; 144.778µs] or [-0.050%; +0.050%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.130µs 1.189µs ± 0.024µs 1.191µs ± 0.018µs 1.210µs 1.214µs 1.215µs 1.215µs 2.09% -0.863 -0.102 1.98% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.185µs; 1.192µs] or [-0.275%; +0.275%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.599µs 4.615µs ± 0.002µs 4.614µs ± 0.001µs 4.616µs 4.618µs 4.622µs 4.624µs 0.21% -0.550 7.690 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 216271971.980op/s 216705754.459op/s ± 116385.824op/s 216716964.895op/s ± 63788.118op/s 216776945.772op/s 216849384.195op/s 216926747.914op/s 217433012.730op/s 0.33% 0.565 7.764 0.05% 8229.721op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.101µs 91.132µs ± 0.522µs 91.080µs ± 0.295µs 91.377µs 91.955µs 92.503µs 94.842µs 4.13% 2.142 11.888 0.57% 0.037µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10543887.253op/s 10973476.565op/s ± 62163.275op/s 10979372.504op/s ± 35522.019op/s 11014488.475op/s 11051854.863op/s 11092448.134op/s 11098689.547op/s 1.09% -1.989 10.593 0.57% 4395.607op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 82.830µs 83.618µs ± 0.555µs 83.556µs ± 0.319µs 83.876µs 84.302µs 85.154µs 88.389µs 5.78% 3.515 26.146 0.66% 0.039µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11313660.198op/s 11959616.562op/s ± 77672.424op/s 11968087.697op/s ± 45450.115op/s 12012437.080op/s 12047092.467op/s 12069535.350op/s 12072858.494op/s 0.88% -3.218 22.837 0.65% 5492.270op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.604µs 4.615µs ± 0.002µs 4.614µs ± 0.001µs 4.616µs 4.619µs 4.620µs 4.625µs 0.23% 0.387 3.045 0.05% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 216222688.415op/s 216704598.231op/s ± 109994.235op/s 216709383.519op/s ± 66012.794op/s 216779151.495op/s 216844734.102op/s 216912592.592op/s 217195270.375op/s 0.22% -0.380 3.045 0.05% 7777.767op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 79.492µs 80.522µs ± 0.419µs 80.531µs ± 0.332µs 80.840µs 81.192µs 81.323µs 81.348µs 1.01% -0.094 -0.724 0.52% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 12292868.848op/s 12419376.913op/s ± 64593.036op/s 12417550.583op/s ± 50990.710op/s 12470527.791op/s 12518665.998op/s 12560542.881op/s 12579944.288op/s 1.31% 0.113 -0.713 0.52% 4567.417op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.265µs 59.472µs ± 0.189µs 59.430µs ± 0.138µs 59.600µs 59.839µs 59.958µs 60.059µs 1.06% 0.851 -0.066 0.32% 0.013µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16650264.350op/s 16814824.008op/s ± 53272.409op/s 16826422.262op/s ± 38978.870op/s 16861690.660op/s 16871759.795op/s 16873133.079op/s 16873429.411op/s 0.28% -0.840 -0.098 0.32% 3766.928op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 7.218µs 7.223µs ± 0.005µs 7.223µs ± 0.002µs 7.224µs 7.226µs 7.229µs 7.284µs 0.85% 8.848 98.416 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 137290511.778op/s 138448025.484op/s ± 98097.777op/s 138451320.521op/s ± 29632.070op/s 138493518.505op/s 138517482.984op/s 138529344.954op/s 138538610.711op/s 0.06% -8.801 97.632 0.07% 6936.560op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.600µs 4.615µs ± 0.002µs 4.614µs ± 0.001µs 4.616µs 4.618µs 4.620µs 4.625µs 0.22% -0.563 9.281 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 216239291.517op/s 216707848.756op/s ± 106065.702op/s 216713011.399op/s ± 59117.657op/s 216769939.429op/s 216841637.932op/s 216874208.717op/s 217395010.143op/s 0.31% 0.579 9.358 0.05% 7499.978op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.847µs 74.384µs ± 0.194µs 74.383µs ± 0.109µs 74.492µs 74.586µs 74.815µs 75.920µs 2.07% 2.195 18.602 0.26% 0.014µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13171845.853op/s 13443874.009op/s ± 34826.206op/s 13443910.008op/s ± 19688.397op/s 13462831.154op/s 13499289.108op/s 13515982.955op/s 13541469.396op/s 0.73% -2.075 17.524 0.26% 2462.585op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 66.341µs 66.876µs ± 0.262µs 66.853µs ± 0.191µs 67.064µs 67.342µs 67.524µs 67.619µs 1.15% 0.331 -0.364 0.39% 0.018µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14788729.687op/s 14953248.243op/s ± 58418.496op/s 14958196.329op/s ± 42901.002op/s 14998105.371op/s 15039837.981op/s 15061816.130op/s 15073577.145op/s 0.77% -0.313 -0.385 0.39% 4130.811op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.605µs 4.615µs ± 0.007µs 4.615µs ± 0.001µs 4.616µs 4.619µs 4.622µs 4.692µs 1.67% 8.945 94.333 0.14% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 213143166.633op/s 216673302.137op/s ± 307067.909op/s 216701574.151op/s ± 63667.543op/s 216765653.482op/s 216863196.126op/s 216915360.817op/s 217150198.125op/s 0.21% -8.876 93.172 0.14% 21712.980op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.471µs 62.665µs ± 0.157µs 62.631µs ± 0.112µs 62.757µs 62.966µs 63.100µs 63.180µs 0.88% 0.932 0.427 0.25% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15827766.988op/s 15958055.145op/s ± 39972.854op/s 15966543.708op/s ± 28594.571op/s 15991691.118op/s 16005849.418op/s 16007015.507op/s 16007372.996op/s 0.26% -0.920 0.395 0.25% 2826.508op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.263µs 59.525µs ± 0.215µs 59.487µs ± 0.173µs 59.654µs 59.929µs 60.014µs 60.069µs 0.98% 0.557 -0.743 0.36% 0.015µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16647444.942op/s 16799862.939op/s ± 60496.072op/s 16810359.608op/s ± 48988.459op/s 16859445.869op/s 16870892.902op/s 16872041.206op/s 16873859.018op/s 0.38% -0.547 -0.761 0.36% 4277.718op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 7.218µs 7.222µs ± 0.002µs 7.223µs ± 0.002µs 7.224µs 7.227µs 7.228µs 7.229µs 0.08% 0.348 -0.478 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 138337757.478op/s 138457573.449op/s ± 43053.272op/s 138454545.373op/s ± 33454.642op/s 138495543.906op/s 138515860.067op/s 138532406.748op/s 138534314.950op/s 0.06% -0.346 -0.480 0.03% 3044.326op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.614µs; 4.615µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ throughput [216689624.503op/s; 216721884.415op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [91.059µs; 91.204µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10964861.333op/s; 10982091.797op/s] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [83.541µs; 83.695µs] or [-0.092%; +0.092%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11948851.911op/s; 11970381.213op/s] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/37828224631 execution_time [4.614µs; 4.615µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631 throughput [216689354.088op/s; 216719842.374op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.463µs; 80.580µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/378282246310005 throughput [12410424.940op/s; 12428328.887op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.446µs; 59.498µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16807440.964op/s; 16822207.052op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/x371413321323331 execution_time [7.222µs; 7.224µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 throughput [138434430.076op/s; 138461620.892op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.614µs; 4.615µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ throughput [216693149.069op/s; 216722548.442op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [74.357µs; 74.411µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13439047.431op/s; 13448700.586op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.840µs; 66.912µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [14945152.001op/s; 14961344.485op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.614µs; 4.616µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216630745.478op/s; 216715858.796op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.643µs; 62.686µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15952515.292op/s; 15963594.998op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.495µs; 59.555µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16791478.765op/s; 16808247.113op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [7.222µs; 7.223µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [138451606.680op/s; 138463540.218op/s] or [-0.004%; +0.004%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.370µs 3.207µs ± 1.395µs 3.059µs ± 0.024µs 3.081µs 3.135µs 13.795µs 14.907µs 387.33% 7.595 57.855 43.38% 0.099µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.014µs; 3.400µs] or [-6.028%; +6.028%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.248µs 37.790µs ± 0.991µs 37.330µs ± 0.051µs 37.454µs 39.851µs 39.893µs 42.222µs 13.11% 1.863 2.150 2.62% 0.070µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.653µs; 37.928µs] or [-0.364%; +0.364%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.611µs 2.670µs ± 0.020µs 2.666µs ± 0.006µs 2.678µs 2.708µs 2.715µs 2.717µs 1.90% -0.222 1.417 0.74% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.667µs; 2.673µs] or [-0.103%; +0.103%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 73.240µs 73.356µs ± 0.145µs 73.339µs ± 0.027µs 73.367µs 73.467µs 73.542µs 75.242µs 2.60% 11.098 140.861 0.20% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [73.336µs; 73.376µs] or [-0.027%; +0.027%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.064ms 9.098ms ± 0.012ms 9.096ms ± 0.007ms 9.106ms 9.116ms 9.124ms 9.132ms 0.39% -0.204 0.541 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.096ms; 9.100ms] or [-0.018%; +0.018%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 623.867µs 624.713µs ± 0.356µs 624.724µs ± 0.225µs 624.936µs 625.317µs 625.524µs 625.829µs 0.18% 0.100 0.011 0.06% 0.025µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1597880.754op/s 1600734.718op/s ± 911.320op/s 1600707.421op/s ± 575.205op/s 1601332.537op/s 1602151.617op/s 1602789.944op/s 1602905.380op/s 0.14% -0.097 0.009 0.06% 64.440op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 461.078µs 462.071µs ± 0.401µs 462.046µs ± 0.258µs 462.311µs 462.776µs 463.070µs 463.119µs 0.23% 0.156 -0.125 0.09% 0.028µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2159270.276op/s 2164169.133op/s ± 1877.071op/s 2164287.166op/s ± 1206.637op/s 2165368.509op/s 2167220.782op/s 2168467.102op/s 2168831.427op/s 0.21% -0.151 -0.126 0.09% 132.729op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 178.148µs 178.371µs ± 0.124µs 178.360µs ± 0.060µs 178.414µs 178.537µs 178.797µs 179.141µs 0.44% 2.481 11.338 0.07% 0.009µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5582204.911op/s 5606288.535op/s ± 3879.135op/s 5606625.609op/s ± 1893.211op/s 5608765.873op/s 5610603.252op/s 5611858.213op/s 5613321.809op/s 0.12% -2.466 11.231 0.07% 274.296op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.640µs 46.801µs ± 0.089µs 46.788µs ± 0.056µs 46.854µs 46.960µs 47.042µs 47.092µs 0.65% 0.678 0.277 0.19% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21235150.831op/s 21367144.232op/s ± 40547.332op/s 21372961.139op/s ± 25795.124op/s 21395786.775op/s 21427884.141op/s 21433878.627op/s 21440868.973op/s 0.32% -0.668 0.255 0.19% 2867.129op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.974µs 49.416µs ± 0.170µs 49.402µs ± 0.102µs 49.513µs 49.734µs 49.862µs 49.992µs 1.19% 0.325 0.630 0.34% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20003153.986op/s 20236528.124op/s ± 69502.264op/s 20242188.372op/s ± 41907.283op/s 20280347.527op/s 20350101.252op/s 20397025.026op/s 20419026.924op/s 0.87% -0.299 0.606 0.34% 4914.552op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [624.664µs; 624.763µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1600608.418op/s; 1600861.018op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [462.016µs; 462.127µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2163908.989op/s; 2164429.276op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [178.354µs; 178.388µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5605750.924op/s; 5606826.146op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.789µs; 46.813µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21361524.762op/s; 21372763.702op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.393µs; 49.440µs] or [-0.048%; +0.048%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20226895.779op/s; 20246160.470op/s] or [-0.048%; +0.048%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c18b159 1730479175 levi/ddcommon-warning
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 257.555ns 268.635ns ± 14.484ns 262.677ns ± 2.352ns 267.673ns 305.466ns 311.795ns 313.722ns 19.43% 2.027 2.700 5.38% 1.024ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [266.628ns; 270.642ns] or [-0.747%; +0.747%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.58%. Comparing base (4f324e7) to head (c18b159).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   70.54%   70.58%   +0.03%     
==========================================
  Files         281      281              
  Lines       41838    41838              
==========================================
+ Hits        29514    29530      +16     
+ Misses      12324    12308      -16     
Components Coverage Δ
crashtracker 19.20% <ø> (ø)
crashtracker-ffi 9.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.93% <ø> (+0.06%) ⬆️
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.74% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.22% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.65% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.13% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.14% <ø> (ø)

@morrisonlevi morrisonlevi enabled auto-merge (squash) October 30, 2024 16:52
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@morrisonlevi morrisonlevi merged commit 66016ac into main Nov 1, 2024
32 checks passed
@morrisonlevi morrisonlevi deleted the levi/ddcommon-warning branch November 1, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants