Fix vendor header name #694

VianneyRuhlmann · 2024-10-25T13:03:16Z

What does this PR do?

The vendor header name in trace utils is not correct.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

pr-commenter · 2024-10-25T13:16:11Z

Benchmarks

Comparison

Benchmark execution time: 2024-10-25 13:15:51

Comparing candidate commit 97455cb in PR branch vianney/trace-utils/fix-header-name with baseline commit a4d6b05 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

🟥 execution_time [+44.293ns; +53.205ns] or [+3.759%; +4.516%]

Candidate

Candidate benchmark details

Group 1

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
sql/obfuscate_sql_string	execution_time	72.318µs	72.444µs ± 0.148µs	72.412µs ± 0.031µs	72.460µs	72.605µs	72.779µs	74.150µs	2.40%	8.263	88.309	0.20%	0.010µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
sql/obfuscate_sql_string	execution_time	[72.423µs; 72.464µs] or [-0.028%; +0.028%]	None	None	None

Group 2

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
concentrator/add_spans_to_concentrator	execution_time	9.064ms	9.097ms ± 0.015ms	9.097ms ± 0.009ms	9.106ms	9.121ms	9.136ms	9.162ms	0.72%	0.633	1.628	0.17%	0.001ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
concentrator/add_spans_to_concentrator	execution_time	[9.095ms; 9.099ms] or [-0.023%; +0.023%]	None	None	None

Group 3

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_trace/test_trace	execution_time	255.901ns	267.037ns ± 15.356ns	261.350ns ± 3.514ns	266.703ns	302.950ns	318.696ns	322.064ns	23.23%	2.146	3.740	5.74%	1.086ns	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_trace/test_trace	execution_time	[264.909ns; 269.165ns] or [-0.797%; +0.797%]	None	None	None

Group 4

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
redis/obfuscate_redis_string	execution_time	37.276µs	37.991µs ± 1.399µs	37.343µs ± 0.035µs	37.422µs	41.037µs	41.064µs	41.217µs	10.37%	1.707	0.929	3.67%	0.099µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
redis/obfuscate_redis_string	execution_time	[37.797µs; 38.185µs] or [-0.510%; +0.510%]	None	None	None

Group 5

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
tags/replace_trace_tags	execution_time	2.639µs	2.690µs ± 0.018µs	2.689µs ± 0.010µs	2.700µs	2.725µs	2.732µs	2.742µs	1.95%	-0.154	1.183	0.68%	0.001µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
tags/replace_trace_tags	execution_time	[2.688µs; 2.693µs] or [-0.094%; +0.094%]	None	None	None

Group 6

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
write only interface	execution_time	1.374µs	3.212µs ± 1.385µs	3.067µs ± 0.028µs	3.093µs	3.132µs	13.783µs	14.923µs	386.64%	7.586	57.829	43.02%	0.098µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
write only interface	execution_time	[3.020µs; 3.404µs] or [-5.977%; +5.977%]	None	None	None

Group 7

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	623.135µs	624.517µs ± 0.529µs	624.549µs ± 0.345µs	624.900µs	625.307µs	625.577µs	625.780µs	0.20%	-0.325	-0.090	0.08%	0.037µs	1	200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	1598004.594op/s	1601237.564op/s ± 1356.554op/s	1601154.661op/s ± 883.772op/s	1602024.180op/s	1603778.273op/s	1604732.970op/s	1604788.322op/s	0.23%	0.329	-0.086	0.08%	95.923op/s	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	461.013µs	462.302µs ± 0.496µs	462.342µs ± 0.366µs	462.651µs	463.123µs	463.256µs	463.582µs	0.27%	-0.062	-0.608	0.11%	0.035µs	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	2157114.208op/s	2163088.894op/s ± 2322.938op/s	2162899.209op/s ± 1711.704op/s	2164894.734op/s	2166769.102op/s	2168181.312op/s	2169138.209op/s	0.29%	0.067	-0.607	0.11%	164.257op/s	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	178.122µs	178.372µs ± 0.114µs	178.372µs ± 0.073µs	178.439µs	178.531µs	178.659µs	179.079µs	0.40%	1.359	6.432	0.06%	0.008µs	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	5584118.549op/s	5606248.051op/s ± 3579.255op/s	5606276.021op/s ± 2297.873op/s	5608734.797op/s	5611489.983op/s	5612276.146op/s	5614128.873op/s	0.14%	-1.347	6.346	0.06%	253.092op/s	1	200
normalization/normalize_service/normalize_service/[empty string]	execution_time	46.793µs	46.979µs ± 0.091µs	46.970µs ± 0.060µs	47.031µs	47.148µs	47.217µs	47.223µs	0.54%	0.597	-0.049	0.19%	0.006µs	1	200
normalization/normalize_service/normalize_service/[empty string]	throughput	21176099.543op/s	21286077.837op/s ± 41264.414op/s	21290024.491op/s ± 27157.881op/s	21316306.093op/s	21344733.339op/s	21358968.395op/s	21370585.042op/s	0.38%	-0.588	-0.062	0.19%	2917.835op/s	1	200
normalization/normalize_service/normalize_service/test_ASCII	execution_time	49.152µs	49.765µs ± 0.205µs	49.750µs ± 0.130µs	49.889µs	50.171µs	50.267µs	50.337µs	1.18%	0.314	0.244	0.41%	0.014µs	1	200
normalization/normalize_service/normalize_service/test_ASCII	throughput	19866235.554op/s	20094838.011op/s ± 82515.248op/s	20100589.433op/s ± 52354.785op/s	20148803.602op/s	20206105.333op/s	20277643.695op/s	20345230.167op/s	1.22%	-0.288	0.242	0.41%	5834.709op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	[624.444µs; 624.591µs] or [-0.012%; +0.012%]	None	None	None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	[1601049.559op/s; 1601425.569op/s] or [-0.012%; +0.012%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	[462.234µs; 462.371µs] or [-0.015%; +0.015%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	[2162766.957op/s; 2163410.831op/s] or [-0.015%; +0.015%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	[178.357µs; 178.388µs] or [-0.009%; +0.009%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	[5605752.001op/s; 5606744.101op/s] or [-0.009%; +0.009%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	execution_time	[46.967µs; 46.992µs] or [-0.027%; +0.027%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	throughput	[21280358.986op/s; 21291796.688op/s] or [-0.027%; +0.027%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	execution_time	[49.737µs; 49.793µs] or [-0.057%; +0.057%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	throughput	[20083402.191op/s; 20106273.831op/s] or [-0.057%; +0.057%]	None	None	None

Group 8

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching string interning on wordpress profile	execution_time	143.382µs	144.128µs ± 0.316µs	144.084µs ± 0.179µs	144.275µs	144.677µs	145.058µs	145.523µs	1.00%	0.987	2.265	0.22%	0.022µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching string interning on wordpress profile	execution_time	[144.084µs; 144.171µs] or [-0.030%; +0.030%]	None	None	None

Group 9

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
two way interface	execution_time	19.832µs	26.857µs ± 11.930µs	20.808µs ± 0.438µs	36.106µs	48.306µs	52.879µs	103.850µs	399.08%	2.839	12.338	44.31%	0.844µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
two way interface	execution_time	[25.203µs; 28.510µs] or [-6.156%; +6.156%]	None	None	None

Group 10

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	190.316µs	193.143µs ± 1.170µs	192.953µs ± 0.737µs	193.942µs	195.058µs	196.062µs	198.648µs	2.95%	0.705	1.776	0.60%	0.083µs	1	200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	5034030.043op/s	5177698.500op/s ± 31247.954op/s	5182598.999op/s ± 19861.957op/s	5199198.750op/s	5222799.651op/s	5240808.223op/s	5254429.865op/s	1.39%	-0.647	1.569	0.60%	2209.564op/s	1	200
normalization/normalize_name/normalize_name/bad-name	execution_time	18.182µs	18.217µs ± 0.026µs	18.223µs ± 0.026µs	18.235µs	18.267µs	18.287µs	18.293µs	0.38%	0.595	-0.345	0.14%	0.002µs	1	200
normalization/normalize_name/normalize_name/bad-name	throughput	54665693.586op/s	54894666.206op/s ± 79331.641op/s	54875024.477op/s ± 77200.306op/s	54967144.799op/s	54984356.599op/s	54990885.076op/s	54998183.180op/s	0.22%	-0.589	-0.361	0.14%	5609.594op/s	1	200
normalization/normalize_name/normalize_name/good	execution_time	11.271µs	11.313µs ± 0.030µs	11.305µs ± 0.013µs	11.330µs	11.348µs	11.366µs	11.604µs	2.64%	4.775	42.656	0.26%	0.002µs	1	200
normalization/normalize_name/normalize_name/good	throughput	86180835.671op/s	88397077.757op/s ± 231025.310op/s	88458758.189op/s ± 104139.285op/s	88533953.815op/s	88626864.183op/s	88669040.831op/s	88721488.691op/s	0.30%	-4.605	40.434	0.26%	16335.956op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	[192.981µs; 193.305µs] or [-0.084%; +0.084%]	None	None	None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	[5173367.834op/s; 5182029.166op/s] or [-0.084%; +0.084%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	execution_time	[18.213µs; 18.220µs] or [-0.020%; +0.020%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	throughput	[54883671.603op/s; 54905660.808op/s] or [-0.020%; +0.020%]	None	None	None
normalization/normalize_name/normalize_name/good	execution_time	[11.309µs; 11.317µs] or [-0.037%; +0.037%]	None	None	None
normalization/normalize_name/normalize_name/good	throughput	[88365059.871op/s; 88429095.643op/s] or [-0.036%; +0.036%]	None	None	None

Group 11

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching deserializing traces from msgpack to their internal representation	execution_time	1.168µs	1.227µs ± 0.022µs	1.229µs ± 0.014µs	1.245µs	1.250µs	1.251µs	1.251µs	1.82%	-1.164	0.668	1.79%	0.002µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching deserializing traces from msgpack to their internal representation	execution_time	[1.224µs; 1.230µs] or [-0.249%; +0.249%]	None	None	None

Group 12

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`97455cb`	1729861520	vianney/trace-utils/fix-header-name

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
credit_card/is_card_number/	execution_time	4.605µs	4.614µs ± 0.002µs	4.614µs ± 0.001µs	4.616µs	4.618µs	4.619µs	4.626µs	0.25%	0.459	4.141	0.05%	0.000µs	1	200
credit_card/is_card_number/	throughput	216172753.139op/s	216716397.660op/s ± 102241.614op/s	216720452.770op/s ± 62681.502op/s	216780614.394op/s	216862959.661op/s	216922721.237op/s	217137953.511op/s	0.19%	-0.451	4.118	0.05%	7229.574op/s	1	200
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	90.100µs	91.317µs ± 0.529µs	91.245µs ± 0.307µs	91.557µs	92.104µs	92.571µs	95.192µs	4.33%	2.203	13.199	0.58%	0.037µs	1	200
credit_card/is_card_number/ 3782-8224-6310-005	throughput	10505048.344op/s	10951276.154op/s ± 62725.290op/s	10959557.057op/s ± 36792.465op/s	10992210.458op/s	11033632.256op/s	11059432.542op/s	11098738.820op/s	1.27%	-2.031	11.686	0.57%	4435.348op/s	1	200
credit_card/is_card_number/ 378282246310005	execution_time	82.755µs	83.701µs ± 0.616µs	83.639µs ± 0.359µs	83.998µs	84.706µs	85.432µs	88.061µs	5.29%	2.185	11.674	0.73%	0.044µs	1	200
credit_card/is_card_number/ 378282246310005	throughput	11355743.262op/s	11947891.746op/s ± 86548.166op/s	11956122.845op/s ± 51246.177op/s	12007440.112op/s	12052419.650op/s	12074326.586op/s	12083882.688op/s	1.07%	-2.000	10.068	0.72%	6119.879op/s	1	200
credit_card/is_card_number/37828224631	execution_time	4.602µs	4.615µs ± 0.003µs	4.614µs ± 0.002µs	4.616µs	4.619µs	4.622µs	4.623µs	0.19%	0.094	2.850	0.06%	0.000µs	1	200
credit_card/is_card_number/37828224631	throughput	216312346.644op/s	216708097.207op/s ± 120389.186op/s	216714064.743op/s ± 72332.783op/s	216786633.363op/s	216876244.480op/s	216914226.247op/s	217293123.309op/s	0.27%	-0.086	2.868	0.06%	8512.801op/s	1	200
credit_card/is_card_number/378282246310005	execution_time	79.305µs	80.518µs ± 0.440µs	80.530µs ± 0.345µs	80.871µs	81.174µs	81.292µs	81.418µs	1.10%	-0.286	-0.634	0.55%	0.031µs	1	200
credit_card/is_card_number/378282246310005	throughput	12282274.575op/s	12419945.041op/s ± 68038.145op/s	12417769.531op/s ± 53259.199op/s	12471516.636op/s	12533256.611op/s	12581023.344op/s	12609610.298op/s	1.54%	0.307	-0.611	0.55%	4811.023op/s	1	200
credit_card/is_card_number/37828224631000521389798	execution_time	59.261µs	59.561µs ± 0.221µs	59.569µs ± 0.189µs	59.746µs	59.939µs	60.072µs	60.098µs	0.89%	0.398	-0.672	0.37%	0.016µs	1	200
credit_card/is_card_number/37828224631000521389798	throughput	16639441.324op/s	16789866.790op/s ± 62231.978op/s	16787346.839op/s ± 53119.442op/s	16853496.148op/s	16872189.570op/s	16873885.014op/s	16874467.244op/s	0.52%	-0.385	-0.690	0.37%	4400.465op/s	1	200
credit_card/is_card_number/x371413321323331	execution_time	7.217µs	7.222µs ± 0.006µs	7.222µs ± 0.002µs	7.224µs	7.225µs	7.228µs	7.299µs	1.06%	11.498	149.168	0.08%	0.000µs	1	200
credit_card/is_card_number/x371413321323331	throughput	137004554.190op/s	138456862.651op/s ± 110385.577op/s	138459825.882op/s ± 30950.638op/s	138497517.432op/s	138520555.066op/s	138539726.960op/s	138568300.315op/s	0.08%	-11.453	148.371	0.08%	7805.439op/s	1	200
credit_card/is_card_number_no_luhn/	execution_time	4.600µs	4.614µs ± 0.003µs	4.614µs ± 0.001µs	4.616µs	4.618µs	4.621µs	4.628µs	0.31%	0.328	8.115	0.06%	0.000µs	1	200
credit_card/is_card_number_no_luhn/	throughput	216062556.887op/s	216714928.578op/s ± 121825.079op/s	216723344.958op/s ± 69803.663op/s	216791203.697op/s	216860151.585op/s	216916673.418op/s	217398476.265op/s	0.31%	-0.311	8.128	0.06%	8614.334op/s	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	73.877µs	74.406µs ± 0.180µs	74.419µs ± 0.092µs	74.511µs	74.632µs	74.737µs	75.459µs	1.40%	0.433	5.293	0.24%	0.013µs	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	13252299.937op/s	13439802.368op/s ± 32440.399op/s	13437419.945op/s ± 16645.502op/s	13454178.767op/s	13496820.763op/s	13524370.917op/s	13535954.202op/s	0.73%	-0.382	5.040	0.24%	2293.883op/s	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	66.327µs	66.842µs ± 0.263µs	66.811µs ± 0.188µs	67.003µs	67.320µs	67.549µs	67.619µs	1.21%	0.555	-0.134	0.39%	0.019µs	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	14788649.495op/s	14960866.619op/s ± 58774.978op/s	14967681.782op/s ± 42135.752op/s	15009311.780op/s	15041501.684op/s	15049027.957op/s	15076864.872op/s	0.73%	-0.536	-0.169	0.39%	4156.019op/s	1	200
credit_card/is_card_number_no_luhn/37828224631	execution_time	4.601µs	4.614µs ± 0.002µs	4.614µs ± 0.001µs	4.616µs	4.618µs	4.620µs	4.621µs	0.15%	-0.332	4.254	0.05%	0.000µs	1	200
credit_card/is_card_number_no_luhn/37828224631	throughput	216394602.298op/s	216715988.528op/s ± 110135.069op/s	216721043.614op/s ± 69000.106op/s	216787349.044op/s	216858855.618op/s	216900035.636op/s	217331064.211op/s	0.28%	0.341	4.296	0.05%	7787.725op/s	1	200
credit_card/is_card_number_no_luhn/378282246310005	execution_time	62.317µs	62.631µs ± 0.154µs	62.606µs ± 0.099µs	62.716µs	62.914µs	63.110µs	63.147µs	0.86%	0.984	0.910	0.25%	0.011µs	1	200
credit_card/is_card_number_no_luhn/378282246310005	throughput	15836129.317op/s	15966718.687op/s ± 39191.468op/s	15972851.744op/s ± 25225.288op/s	15997214.885op/s	16008029.549op/s	16030175.628op/s	16047057.998op/s	0.46%	-0.970	0.874	0.24%	2771.255op/s	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	59.263µs	59.530µs ± 0.217µs	59.503µs ± 0.175µs	59.657µs	59.940µs	60.070µs	60.106µs	1.01%	0.633	-0.375	0.36%	0.015µs	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	16637310.397op/s	16798382.565op/s ± 61009.841op/s	16805738.321op/s ± 49507.054op/s	16859440.911op/s	16870877.339op/s	16872565.005op/s	16874046.692op/s	0.41%	-0.619	-0.403	0.36%	4314.047op/s	1	200
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	7.218µs	7.223µs ± 0.004µs	7.223µs ± 0.002µs	7.224µs	7.227µs	7.231µs	7.262µs	0.54%	5.711	52.924	0.05%	0.000µs	1	200
credit_card/is_card_number_no_luhn/x371413321323331	throughput	137706699.247op/s	138447943.329op/s ± 73153.649op/s	138446054.495op/s ± 34362.785op/s	138492137.111op/s	138517016.123op/s	138534882.530op/s	138539151.164op/s	0.07%	-5.676	52.441	0.05%	5172.744op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
credit_card/is_card_number/	execution_time	[4.614µs; 4.615µs] or [-0.007%; +0.007%]	None	None	None
credit_card/is_card_number/	throughput	[216702227.956op/s; 216730567.365op/s] or [-0.007%; +0.007%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	[91.243µs; 91.390µs] or [-0.080%; +0.080%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	throughput	[10942583.032op/s; 10959969.276op/s] or [-0.079%; +0.079%]	None	None	None
credit_card/is_card_number/ 378282246310005	execution_time	[83.616µs; 83.787µs] or [-0.102%; +0.102%]	None	None	None
credit_card/is_card_number/ 378282246310005	throughput	[11935897.003op/s; 11959886.490op/s] or [-0.100%; +0.100%]	None	None	None
credit_card/is_card_number/37828224631	execution_time	[4.614µs; 4.615µs] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number/37828224631	throughput	[216691412.424op/s; 216724781.991op/s] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number/378282246310005	execution_time	[80.457µs; 80.579µs] or [-0.076%; +0.076%]	None	None	None
credit_card/is_card_number/378282246310005	throughput	[12410515.609op/s; 12429374.474op/s] or [-0.076%; +0.076%]	None	None	None
credit_card/is_card_number/37828224631000521389798	execution_time	[59.530µs; 59.591µs] or [-0.051%; +0.051%]	None	None	None
credit_card/is_card_number/37828224631000521389798	throughput	[16781242.036op/s; 16798491.543op/s] or [-0.051%; +0.051%]	None	None	None
credit_card/is_card_number/x371413321323331	execution_time	[7.222µs; 7.223µs] or [-0.011%; +0.011%]	None	None	None
credit_card/is_card_number/x371413321323331	throughput	[138441564.272op/s; 138472161.031op/s] or [-0.011%; +0.011%]	None	None	None
credit_card/is_card_number_no_luhn/	execution_time	[4.614µs; 4.615µs] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number_no_luhn/	throughput	[216698044.793op/s; 216731812.362op/s] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	[74.381µs; 74.431µs] or [-0.033%; +0.033%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	[13435306.441op/s; 13444298.296op/s] or [-0.033%; +0.033%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	[66.806µs; 66.879µs] or [-0.055%; +0.055%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	[14952720.972op/s; 14969012.265op/s] or [-0.054%; +0.054%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	execution_time	[4.614µs; 4.615µs] or [-0.007%; +0.007%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	throughput	[216700724.867op/s; 216731252.190op/s] or [-0.007%; +0.007%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	execution_time	[62.609µs; 62.652µs] or [-0.034%; +0.034%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	throughput	[15961287.127op/s; 15972150.248op/s] or [-0.034%; +0.034%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	[59.500µs; 59.560µs] or [-0.050%; +0.050%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	[16789927.188op/s; 16806837.942op/s] or [-0.050%; +0.050%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	[7.222µs; 7.223µs] or [-0.007%; +0.007%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	throughput	[138437804.937op/s; 138458081.721op/s] or [-0.007%; +0.007%]	None	None	None

Baseline

Omitted due to size.

codecov-commenter · 2024-10-25T13:16:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.80%. Comparing base (a4d6b05) to head (97455cb).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
+ Coverage   71.76%   71.80%   +0.03%     
==========================================
  Files         271      271              
  Lines       41011    41032      +21     
==========================================
+ Hits        29433    29461      +28     
+ Misses      11578    11571       -7

Components	Coverage Δ
crashtracker	`20.27% <ø> (ø)`
crashtracker-ffi	`9.07% <ø> (ø)`
datadog-alloc	`98.73% <ø> (ø)`
data-pipeline	`91.92% <ø> (ø)`
data-pipeline-ffi	`0.00% <ø> (ø)`
ddcommon	`82.74% <ø> (ø)`
ddcommon-ffi	`69.12% <ø> (ø)`
ddtelemetry	`59.10% <ø> (ø)`
ddtelemetry-ffi	`22.13% <ø> (ø)`
dogstatsd	`88.86% <ø> (ø)`
dogstatsd-client	`79.77% <ø> (ø)`
ipc	`82.65% <ø> (ø)`
profiling	`84.30% <ø> (ø)`
profiling-ffi	`77.46% <ø> (ø)`
serverless	`0.00% <ø> (ø)`
sidecar	`36.09% <ø> (ø)`
sidecar-ffi	`0.00% <ø> (ø)`
spawn-worker	`50.36% <ø> (ø)`
tinybytes	`94.77% <ø> (ø)`
trace-mini-agent	`72.45% <ø> (ø)`
trace-normalization	`98.25% <ø> (ø)`
trace-obfuscation	`95.77% <ø> (ø)`
trace-protobuf	`77.67% <ø> (ø)`
trace-utils	`93.11% <100.00%> (+0.03%)`	⬆️

VianneyRuhlmann requested review from a team as code owners October 25, 2024 13:03

github-actions bot added the mini-agent label Oct 25, 2024

Fix vendor header name

97455cb

VianneyRuhlmann force-pushed the vianney/trace-utils/fix-header-name branch from 5ac3e61 to 97455cb Compare October 25, 2024 13:05

bantonsson approved these changes Oct 25, 2024

View reviewed changes

VianneyRuhlmann merged commit 085a91a into main Oct 25, 2024
32 checks passed

VianneyRuhlmann deleted the vianney/trace-utils/fix-header-name branch October 25, 2024 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix vendor header name #694

Fix vendor header name #694

VianneyRuhlmann commented Oct 25, 2024

pr-commenter bot commented Oct 25, 2024

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Group 12

codecov-commenter commented Oct 25, 2024

Fix vendor header name #694

Fix vendor header name #694

Conversation

VianneyRuhlmann commented Oct 25, 2024

What does this PR do?

Motivation

Additional Notes

How to test the change?

pr-commenter bot commented Oct 25, 2024

Benchmarks

Comparison

scenario:benching deserializing traces from msgpack to their internal representation

Candidate

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Group 12

Baseline

codecov-commenter commented Oct 25, 2024

Codecov Report