Allow attaching to the sidecar via gdb #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/sidecar-proc-fd
branch
from
8a01bf4 to
549a16d
Compare
It worked when DD_SPAWN_WORKER_USE_EXEC=1 was set, but not generally. Having a /proc/<pid>/X path will tell gdb exactly where to find it, instead of a /proc/self/fd/X which is pointing into gdbs own process from the perspective of gdb. This also prevented sidecar core dumps from being opened with gdb, which was rather ugly. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/sidecar-proc-fd
branch
from
549a16d to
1a7d347
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 71.79% 71.82% +0.03%
==========================================
Files 271 271
Lines 40982 40982
==========================================
+ Hits 29422 29435 +13
+ Misses 11560 11547 -13
|
BenchmarksComparisonBenchmark execution time: 2024-10-22 16:16:04 Comparing candidate commit 1a7d347 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
ekump
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It worked when DD_SPAWN_WORKER_USE_EXEC=1 was set, but not generally. Having a /proc//X path will tell gdb exactly where to find it, instead of a /proc/self/fd/X which is pointing into gdbs own process from the perspective of gdb.
This also prevented sidecar core dumps from being opened with gdb, which was rather ugly.
(Also updates the Cargo.toml of trace-utils to include the required hyper runtime, otherwise the server feature will fail to compile...)