-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict RC path to a definite 31 chars #676
Conversation
Fixes DataDog/dd-trace-php#2892. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
BenchmarksComparisonBenchmark execution time: 2024-10-17 09:28:46 Comparing candidate commit eca6525 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics. scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage ? 71.78%
=======================================
Files ? 271
Lines ? 40979
Branches ? 0
=======================================
Hits ? 29415
Misses ? 11564
Partials ? 0
|
Fixes DataDog/dd-trace-php#2892.