Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict RC path to a definite 31 chars #676

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Restrict RC path to a definite 31 chars #676

merged 2 commits into from
Oct 17, 2024

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Oct 15, 2024

Fixes DataDog/dd-trace-php#2892.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested review from a team as code owners October 15, 2024 11:16
@pr-commenter
Copy link

pr-commenter bot commented Oct 15, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-10-17 09:28:46

Comparing candidate commit eca6525 in PR branch 31-char-shm with baseline commit 92272e9 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟥 execution_time [+7.860µs; +8.497µs] or [+8.020%; +8.670%]
  • 🟥 throughput [-810316.418op/s; -752952.734op/s] or [-7.942%; -7.380%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.233µs 142.157µs ± 0.608µs 142.112µs ± 0.205µs 142.316µs 142.644µs 143.785µs 148.695µs 4.63% 6.671 67.042 0.43% 0.043µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.073µs; 142.241µs] or [-0.059%; +0.059%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.847µs 23.824µs ± 12.003µs 18.515µs ± 0.237µs 19.023µs 45.183µs 49.891µs 106.328µs 474.28% 3.508 17.698 50.25% 0.849µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.160µs; 25.487µs] or [-6.982%; +6.982%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.503µs 38.062µs ± 0.972µs 37.600µs ± 0.051µs 37.750µs 40.097µs 40.123µs 42.016µs 11.74% 1.790 1.631 2.55% 0.069µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.927µs; 38.197µs] or [-0.354%; +0.354%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.397µs 3.183µs ± 1.378µs 3.039µs ± 0.025µs 3.059µs 3.113µs 13.765µs 14.776µs 386.30% 7.586 57.771 43.17% 0.097µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.992µs; 3.374µs] or [-5.998%; +5.998%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 255.985ns 269.959ns ± 15.484ns 262.757ns ± 5.274ns 277.543ns 304.625ns 311.366ns 316.548ns 20.47% 1.284 0.613 5.72% 1.095ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [267.813ns; 272.105ns] or [-0.795%; +0.795%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.635µs 2.688µs ± 0.017µs 2.686µs ± 0.005µs 2.691µs 2.732µs 2.737µs 2.741µs 2.02% 0.798 2.738 0.65% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.685µs; 2.690µs] or [-0.090%; +0.090%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.014µs 2.015µs 2.018µs 2.027µs 0.68% 6.297 56.775 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 493245241.812op/s 496543688.812op/s ± 323148.571op/s 496606530.376op/s ± 119112.792op/s 496712145.185op/s 496774079.573op/s 496802755.140op/s 496818103.147op/s 0.04% -6.260 56.239 0.06% 22850.055op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 117.876µs 118.937µs ± 0.536µs 118.846µs ± 0.265µs 119.147µs 119.721µs 120.844µs 121.757µs 2.45% 1.846 6.257 0.45% 0.038µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8213099.198op/s 8408013.694op/s ± 37563.665op/s 8414217.474op/s ± 18755.259op/s 8429943.888op/s 8453900.038op/s 8463408.477op/s 8483466.572op/s 0.82% -1.782 5.909 0.45% 2656.152op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 109.368µs 110.166µs ± 0.302µs 110.173µs ± 0.162µs 110.319µs 110.630µs 111.045µs 111.217µs 0.95% 0.290 1.056 0.27% 0.021µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8991424.947op/s 9077311.295op/s ± 24857.629op/s 9076616.369op/s ± 13354.408op/s 9092313.588op/s 9117361.130op/s 9134185.311op/s 9143422.112op/s 0.74% -0.266 1.026 0.27% 1757.700op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.014µs 2.015µs 2.016µs 2.027µs 0.66% 8.615 101.180 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 493266161.991op/s 496544527.227op/s ± 274193.800op/s 496522865.173op/s ± 106609.787op/s 496690596.385op/s 496797549.062op/s 496819103.696op/s 496869402.590op/s 0.07% -8.567 100.423 0.06% 19388.430op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 104.987µs 106.281µs ± 0.372µs 106.275µs ± 0.201µs 106.476µs 106.927µs 107.271µs 107.510µs 1.16% 0.201 1.085 0.35% 0.026µs 1 200
credit_card/is_card_number/378282246310005 throughput 9301477.633op/s 9409124.947op/s ± 32879.580op/s 9409525.534op/s ± 17824.446op/s 9427510.462op/s 9464262.952op/s 9475682.695op/s 9525013.638op/s 1.23% -0.170 1.077 0.35% 2324.937op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 103.612µs 105.019µs ± 0.617µs 104.962µs ± 0.431µs 105.442µs 106.132µs 106.449µs 106.646µs 1.60% 0.309 -0.245 0.59% 0.044µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9376853.394op/s 9522409.596op/s ± 55860.533op/s 9527299.565op/s ± 39299.137op/s 9562555.667op/s 9603937.554op/s 9635750.695op/s 9651349.037op/s 1.30% -0.280 -0.263 0.59% 3949.936op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 23.242µs 24.067µs ± 0.372µs 24.009µs ± 0.277µs 24.428µs 24.613µs 24.828µs 25.281µs 5.30% 0.096 -0.388 1.54% 0.026µs 1 200
credit_card/is_card_number/x371413321323331 throughput 39555231.446op/s 41560713.570op/s ± 642480.830op/s 41650439.325op/s ± 480963.303op/s 41946248.399op/s 42609421.084op/s 42932791.929op/s 43026279.830op/s 3.30% -0.023 -0.438 1.54% 45430.255op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.001µs 2.014µs 2.016µs 2.016µs 2.019µs 0.24% 1.426 3.958 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 495359224.215op/s 496526921.781op/s ± 210953.209op/s 496536567.462op/s ± 150704.075op/s 496695402.770op/s 496755452.167op/s 496785313.839op/s 496803291.907op/s 0.05% -1.421 3.925 0.04% 14916.644op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 98.776µs 106.188µs ± 2.271µs 106.352µs ± 1.539µs 107.878µs 109.559µs 110.259µs 110.471µs 3.87% -0.464 0.027 2.13% 0.161µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 9052141.670op/s 9421554.294op/s ± 203797.948op/s 9402763.684op/s ± 135329.108op/s 9541290.945op/s 9776418.450op/s 9992408.937op/s 10123874.665op/s 7.67% 0.584 0.270 2.16% 14410.691op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 87.859µs 88.791µs ± 0.382µs 88.797µs ± 0.248µs 89.012µs 89.409µs 89.675µs 90.052µs 1.41% 0.102 0.296 0.43% 0.027µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11104639.410op/s 11262569.441op/s ± 48446.589op/s 11261670.396op/s ± 31485.387op/s 11294361.868op/s 11346399.200op/s 11373867.524op/s 11381831.957op/s 1.07% -0.073 0.275 0.43% 3425.691op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.013µs 2.014µs ± 0.001µs 2.014µs ± 0.000µs 2.014µs 2.015µs 2.017µs 2.019µs 0.27% 1.861 6.659 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 495306408.254op/s 496565566.294op/s ± 207133.881op/s 496622099.683op/s ± 118077.130op/s 496714778.367op/s 496790402.374op/s 496830087.481op/s 496856825.293op/s 0.05% -1.855 6.611 0.04% 14646.577op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 83.709µs 84.783µs ± 0.458µs 84.796µs ± 0.315µs 85.082µs 85.580µs 85.883µs 86.293µs 1.77% 0.242 -0.027 0.54% 0.032µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11588367.440op/s 11795092.948op/s ± 63591.450op/s 11793067.520op/s ± 43834.468op/s 11842581.483op/s 11898318.013op/s 11924903.784op/s 11946106.860op/s 1.30% -0.211 -0.059 0.54% 4496.595op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 103.740µs 104.881µs ± 0.587µs 104.896µs ± 0.383µs 105.206µs 105.870µs 106.367µs 106.607µs 1.63% 0.339 -0.162 0.56% 0.042µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9380221.412op/s 9534900.990op/s ± 53306.999op/s 9533216.010op/s ± 34843.242op/s 9572151.040op/s 9619968.850op/s 9633911.455op/s 9639504.618op/s 1.11% -0.311 -0.194 0.56% 3769.374op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 23.241µs 24.057µs ± 0.359µs 24.036µs ± 0.253µs 24.370µs 24.582µs 24.893µs 24.956µs 3.83% -0.082 -0.322 1.49% 0.025µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 40070903.291op/s 41577295.482op/s ± 620713.091op/s 41603947.561op/s ± 436443.539op/s 41991409.949op/s 42650731.671op/s 43018895.281op/s 43028242.702op/s 3.42% 0.156 -0.300 1.49% 43891.044op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.014µs; 2.014µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [496498903.528op/s; 496588474.096op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [118.862µs; 119.011µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8402807.731op/s; 8413219.657op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [110.124µs; 110.207µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9073866.267op/s; 9080756.324op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/37828224631 execution_time [2.014µs; 2.014µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [496506526.604op/s; 496582527.851op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [106.230µs; 106.333µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/378282246310005 throughput [9404568.153op/s; 9413681.740op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [104.934µs; 105.105µs] or [-0.081%; +0.081%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9514667.863op/s; 9530151.328op/s] or [-0.081%; +0.081%] None None None
credit_card/is_card_number/x371413321323331 execution_time [24.015µs; 24.119µs] or [-0.214%; +0.214%] None None None
credit_card/is_card_number/x371413321323331 throughput [41471671.906op/s; 41649755.233op/s] or [-0.214%; +0.214%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.014µs; 2.014µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ throughput [496497685.696op/s; 496556157.867op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [105.874µs; 106.503µs] or [-0.296%; +0.296%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [9393309.859op/s; 9449798.730op/s] or [-0.300%; +0.300%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [88.738µs; 88.844µs] or [-0.060%; +0.060%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11255855.210op/s; 11269283.673op/s] or [-0.060%; +0.060%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.014µs; 2.014µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [496536859.531op/s; 496594273.058op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [84.720µs; 84.847µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [11786279.784op/s; 11803906.111op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [104.800µs; 104.963µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9527513.153op/s; 9542288.828op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [24.007µs; 24.107µs] or [-0.207%; +0.207%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [41491270.618op/s; 41663320.347op/s] or [-0.207%; +0.207%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 622.981µs 624.773µs ± 0.444µs 624.773µs ± 0.293µs 625.073µs 625.448µs 625.597µs 626.886µs 0.34% 0.063 2.798 0.07% 0.031µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1595187.456op/s 1600581.765op/s ± 1137.153op/s 1600580.416op/s ± 751.630op/s 1601326.814op/s 1602391.519op/s 1602976.336op/s 1605184.471op/s 0.29% -0.053 2.783 0.07% 80.409op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 461.167µs 462.308µs ± 0.465µs 462.311µs ± 0.307µs 462.612µs 463.008µs 463.561µs 463.663µs 0.29% 0.156 0.147 0.10% 0.033µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2156737.859op/s 2163063.714op/s ± 2174.625op/s 2163047.689op/s ± 1435.275op/s 2164488.479op/s 2166535.161op/s 2167715.011op/s 2168413.114op/s 0.25% -0.149 0.141 0.10% 153.769op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 178.095µs 178.405µs ± 0.138µs 178.388µs ± 0.080µs 178.471µs 178.690µs 178.894µs 178.928µs 0.30% 1.014 1.800 0.08% 0.010µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5588837.918op/s 5605226.283op/s ± 4334.061op/s 5605773.564op/s ± 2517.433op/s 5608015.578op/s 5610952.919op/s 5613425.492op/s 5614995.379op/s 0.16% -1.007 1.781 0.08% 306.464op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.654µs 46.801µs ± 0.070µs 46.800µs ± 0.051µs 46.852µs 46.917µs 46.965µs 47.026µs 0.48% 0.325 -0.145 0.15% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21265024.645op/s 21367070.644op/s ± 32015.234op/s 21367312.513op/s ± 23080.181op/s 21389953.299op/s 21415551.392op/s 21427470.955op/s 21434451.244op/s 0.31% -0.317 -0.157 0.15% 2263.819op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.975µs 49.383µs ± 0.198µs 49.366µs ± 0.129µs 49.496µs 49.685µs 49.826µs 50.689µs 2.68% 1.595 8.286 0.40% 0.014µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19728087.314op/s 20250290.168op/s ± 80687.073op/s 20257031.105op/s ± 53074.901op/s 20309326.400op/s 20354026.894op/s 20389526.206op/s 20418382.147op/s 0.80% -1.504 7.600 0.40% 5705.438op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [624.712µs; 624.835µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1600424.167op/s; 1600739.364op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [462.243µs; 462.372µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2162762.331op/s; 2163365.096op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [178.386µs; 178.424µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5604625.624op/s; 5605826.942op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.791µs; 46.811µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21362633.640op/s; 21371507.647op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.355µs; 49.410µs] or [-0.056%; +0.056%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20239107.716op/s; 20261472.621op/s] or [-0.055%; +0.055%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 79.246µs 79.411µs ± 0.151µs 79.398µs ± 0.042µs 79.438µs 79.517µs 79.693µs 81.297µs 2.39% 9.819 119.358 0.19% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [79.390µs; 79.432µs] or [-0.026%; +0.026%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.860ms 8.887ms ± 0.012ms 8.886ms ± 0.007ms 8.893ms 8.908ms 8.916ms 8.936ms 0.56% 0.718 1.789 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.885ms; 8.889ms] or [-0.019%; +0.019%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.122µs 1.176µs ± 0.021µs 1.180µs ± 0.013µs 1.193µs 1.197µs 1.198µs 1.198µs 1.52% -1.153 0.649 1.75% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.173µs; 1.178µs] or [-0.243%; +0.243%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz eca6525 1729156703 31-char-shm
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 191.381µs 193.597µs ± 0.894µs 193.639µs ± 0.615µs 194.234µs 194.964µs 195.471µs 196.298µs 1.37% -0.159 -0.127 0.46% 0.063µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5094305.652op/s 5165469.412op/s ± 23867.938op/s 5164261.572op/s ± 16343.252op/s 5180871.203op/s 5205857.026op/s 5222996.997op/s 5225169.753op/s 1.18% 0.184 -0.128 0.46% 1687.718op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.198µs 18.230µs ± 0.023µs 18.240µs ± 0.021µs 18.249µs 18.257µs 18.294µs 18.311µs 0.39% 0.320 -0.607 0.13% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54613245.656op/s 54855843.216op/s ± 70043.551op/s 54824192.059op/s ± 62182.877op/s 54924595.048op/s 54940890.121op/s 54946658.625op/s 54951502.970op/s 0.23% -0.315 -0.624 0.13% 4952.827op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.270µs 11.327µs ± 0.045µs 11.318µs ± 0.016µs 11.341µs 11.372µs 11.409µs 11.840µs 4.61% 7.773 85.581 0.39% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 84457286.057op/s 88285605.662op/s ± 337922.050op/s 88354040.161op/s ± 125298.531op/s 88454479.126op/s 88555566.390op/s 88653887.813op/s 88727638.729op/s 0.42% -7.458 80.666 0.38% 23894.697op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [193.473µs; 193.721µs] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5162161.546op/s; 5168777.279op/s] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.226µs; 18.233µs] or [-0.018%; +0.018%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54846135.853op/s; 54865550.579op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.321µs; 11.333µs] or [-0.055%; +0.055%] None None None
normalization/normalize_name/normalize_name/good throughput [88238772.916op/s; 88332438.408op/s] or [-0.053%; +0.053%] None None None

Baseline

Omitted due to size.

Copy link
Contributor

@hoolioh hoolioh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@92272e9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage        ?   71.78%           
=======================================
  Files           ?      271           
  Lines           ?    40979           
  Branches        ?        0           
=======================================
  Hits            ?    29415           
  Misses          ?    11564           
  Partials        ?        0           
Components Coverage Δ
crashtracker 20.41% <ø> (?)
crashtracker-ffi 9.07% <ø> (?)
datadog-alloc 98.73% <ø> (?)
data-pipeline 91.92% <ø> (?)
data-pipeline-ffi 0.00% <ø> (?)
ddcommon 82.73% <ø> (?)
ddcommon-ffi 69.12% <ø> (?)
ddtelemetry 59.10% <ø> (?)
ddtelemetry-ffi 22.13% <ø> (?)
dogstatsd 88.86% <ø> (?)
dogstatsd-client 79.77% <ø> (?)
ipc 82.65% <ø> (?)
profiling 84.26% <ø> (?)
profiling-ffi 77.42% <ø> (?)
serverless 0.00% <ø> (?)
sidecar 36.09% <100.00%> (?)
sidecar-ffi 0.00% <ø> (?)
spawn-worker 50.36% <ø> (?)
tinybytes 94.77% <ø> (?)
trace-mini-agent 72.45% <ø> (?)
trace-normalization 98.25% <ø> (?)
trace-obfuscation 95.73% <ø> (?)
trace-protobuf 77.67% <ø> (?)
trace-utils 93.07% <ø> (?)

@bwoebi bwoebi merged commit 2820fd0 into main Oct 17, 2024
30 checks passed
@bwoebi bwoebi deleted the 31-char-shm branch October 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Appsec warning: Remote config path too long
3 participants