Fix the trace payload size hint #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The incoming buffer may be much larger than the actual contained data. The decoder knows where the payload starts and ends, but the sidecar send_trace_v04 method does not. This ensures proper trace coalescing, leading to less individual http requests. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/fix-payload-size
branch
from
fe21d84 to
80d69c1
Compare
BenchmarksComparisonBenchmark execution time: 2024-10-03 17:32:10 Comparing candidate commit ce20078 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
ekump
approved these changes
Oct 3, 2024
| @@ -47,49 +47,56 @@ use tinybytes::{Bytes, BytesString}; | |||
| /// }; | |||
| /// let encoded_data = to_vec_named(&vec![vec![span]]).unwrap(); | |||
| /// let encoded_data_as_tinybytes = tinybytes::Bytes::from(encoded_data); | |||
| /// let decoded_traces = from_slice(encoded_data_as_tinybytes).expect("Decoding failed"); | |||
| /// let (decoded_traces, _) = from_slice(encoded_data_as_tinybytes).expect("Decoding failed"); | |||
There was a problem hiding this comment.
Suggested change
| /// let (decoded_traces, _) = from_slice(encoded_data_as_tinybytes).expect("Decoding failed"); | |
| /// let (decoded_traces, _payload_size) = from_slice(encoded_data_as_tinybytes).expect("Decoding failed"); |
I think it's helpful to at least name the variable, even if we don't use it in the example.
| @@ -270,7 +277,7 @@ mod tests { | |||
| ..Default::default() | |||
| }; | |||
| let encoded_data = rmp_serde::to_vec_named(&vec![vec![span]]).unwrap(); | |||
| let decoded_traces = | |||
| let (decoded_traces, _) = | |||
There was a problem hiding this comment.
We should probably have at least one unit test that checks we're returning the correct size.
bwoebi
force-pushed
the
bob/fix-payload-size
branch
from
cc34227 to
ce20078
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 71.78% 71.79% +0.01%
==========================================
Files 271 271
Lines 40895 40912 +17
==========================================
+ Hits 29357 29374 +17
Misses 11538 11538
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incoming buffer may be much larger than the actual contained data. The decoder knows where the payload starts and ends, but the sidecar send_trace_v04 method does not.
This ensures proper trace coalescing, leading to less individual http requests.