-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider ifunc symbols also defined #609
Conversation
Looks like php may be built with certain optimizations causing some symbols to be resolved as ifunc. The object crate is not recognizing these as definition, but for our purposes, it is one. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
610f2f4
to
6ae62d9
Compare
BenchmarksComparisonBenchmark execution time: 2024-09-05 19:12:53 Comparing candidate commit f802a21 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 72.73% 72.67% -0.07%
==========================================
Files 246 246
Lines 34940 34947 +7
==========================================
- Hits 25412 25396 -16
- Misses 9528 9551 +23
|
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
7c0de1d
to
f802a21
Compare
Looks like php may be built with certain optimizations causing some symbols to be resolved as ifunc. The object crate is not recognizing these as definition, but for our purposes, it is one.
Fixes part of DataDog/dd-trace-php#2831.