Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flush interval in telemetry configurable via sidecar #527

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

cataphract
Copy link
Contributor

Environment variables read via environ when sidecar is spawned are not necessarily available (see https://gist.github.com/cataphract/78ca7cabdded79360d790a8bc249e93d ). Add telemetry flush interval as a session config entry instead.

@cataphract cataphract requested review from a team as code owners July 11, 2024 10:44
@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2024

Benchmarks

This comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.21%. Comparing base (ccc5efc) to head (2cca88b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   70.22%   70.21%   -0.02%     
==========================================
  Files         206      206              
  Lines       27810    27815       +5     
==========================================
  Hits        19530    19530              
- Misses       8280     8285       +5     
Components Coverage Δ
crashtracker 16.86% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 51.15% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.41% <ø> (ø)
ddcommon-ffi 75.31% <ø> (ø)
ddtelemetry 59.02% <ø> (ø)
ipc 84.13% <ø> (ø)
profiling 78.68% <ø> (ø)
profiling-ffi 58.26% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 35.64% <0.00%> (-0.05%) ⬇️
sidecar-ffi 0.00% <0.00%> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 70.93% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 89.91% <ø> (ø)

Copy link
Contributor

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@cataphract cataphract force-pushed the glopes/flush-interval branch from b350c8a to f49385d Compare July 11, 2024 13:36
@cataphract cataphract force-pushed the glopes/flush-interval branch from f49385d to 2cca88b Compare July 11, 2024 13:37
@cataphract cataphract merged commit 6a145ea into main Jul 11, 2024
32 checks passed
@cataphract cataphract deleted the glopes/flush-interval branch July 11, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants