fix nightly lints surprise build breakage #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
force-pushed
the
pawel/fix_nightly_lints_surprise_build_breakage
branch
3 times, most recently
from
94f29a2 to
dd4c73f
Compare
pawelchcki
force-pushed
the
pawel/fix_nightly_lints_surprise_build_breakage
branch
2 times, most recently
from
4560034 to
a986cf0
Compare
pawelchcki
force-pushed
the
pawel/fix_nightly_lints_surprise_build_breakage
branch
from
a986cf0 to
167fbce
Compare
pawelchcki
force-pushed
the
pawel/fix_nightly_lints_surprise_build_breakage
branch
from
c1fbbed to
a9dfe92
Compare
Nightly has a few more lints, and I think it might be worth keeping, for now, since its track record seems somewhat good so far. I've added stable version + improved caching. |
| ~/.cargo/git/db/ | ||
| ~/.cargo/bin/ | ||
| ~/.cargo/.crates.toml | ||
| key: "v1-0.5.0" |
There was a problem hiding this comment.
This number is magic to me; where does it come from?
There was a problem hiding this comment.
Its bundle licences v0.5.0 is the currently installed version. hmm maybe I should add a comment
morrisonlevi
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly builds that pull in latest lints daily, often cause us to chase broken tests.
In a few cases it turned out that the clippy checks were later removed - while we've lost time fixing code to keep the tests up to date.
This PR introduces adds latest "stable" clippy to be used as reference against latest nightly - and allows other builds in the matrix to finish if one of them fails.
Additionally it improves the caching on lints, and should reduce their execution time to seconds, instead of minutes