Fix compilation error for old version of GCC #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
approved these changes
Aug 31, 2022
ddcommon-ffi/cbindgen.toml
Outdated
| @@ -22,12 +22,23 @@ after_includes = """ | |||
| /* NOTE: Compilation fails if you pass in a char* instead of a literal */ ((ddog_CharSlice){ .ptr = "" string, .len = sizeof(string) - 1 }) | |||
| #endif | |||
|
|
|||
| #if defined __GNUC__ | |||
| # define DDOG_GNUC_VERSION(major) __GNUC__ >= 4 | |||
There was a problem hiding this comment.
major never gets used -- was the intention to use __GNUC__ >= major in the macro? 🤔
There was a problem hiding this comment.
oh yeah, good one. Will fix it
sanchda
approved these changes
Aug 31, 2022
| # define DDOG_GNUC_VERSION(major) (0) | ||
| #endif | ||
|
|
||
| #if defined __has_attribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the C/C++ macro in the common.h file.
Motivation
This PR fixes the issue #47 for old GCC version.
How to test the change?
What I have done to validate the fix:
common.hwith a newer version of GCC (10.2.1)common.h(what you have in the fix)