Add metrics #450
Merged
Add metrics #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoolioh
force-pushed
the
julio/APMSP-1004-add-metrics
branch
6 times, most recently
from
e23a999 to
f297af0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 68.55% 68.95% +0.39%
==========================================
Files 193 193
Lines 25082 25569 +487
==========================================
+ Hits 17195 17630 +435
- Misses 7887 7939 +52
|
hoolioh
force-pushed
the
julio/APMSP-1004-add-metrics
branch
from
f297af0 to
512cdc5
Compare
pierotibou
reviewed
May 24, 2024
There was a problem hiding this comment.
Thanks a lot for doing this. TLDR, I assume we should comment the sending of the bytes metrics (we can keep the rest) as it's not yet supported. And add a few missing s to metric names.
The rest is mainly questions for my knowledge and some nitpicks that you should ignore :p
|
As an experiment to get rid of |
hoolioh
force-pushed
the
julio/APMSP-1004-add-metrics
branch
2 times, most recently
from
5bbddcb to
dbb87cd
Compare
bantonsson
reviewed
May 27, 2024
sidecar/src/self_telemetry.rs
Outdated
| } | ||
| if trace_metrics.chunks_sent > 0 { | ||
| futures.push(self.send( | ||
| self.trace_chunk_sent, |
There was a problem hiding this comment.
I see that I'm late to the game...
hoolioh
force-pushed
the
julio/APMSP-1004-add-metrics
branch
from
dbb87cd to
711e6e2
Compare
pierotibou
approved these changes
May 28, 2024
bantonsson
approved these changes
May 28, 2024
hoolioh
force-pushed
the
julio/APMSP-1004-add-metrics
branch
from
711e6e2 to
b34e8ce
Compare
ekump
reviewed
May 29, 2024
hoolioh
force-pushed
the
julio/APMSP-1004-add-metrics
branch
from
b34e8ce to
19ca4c1
Compare
ekump
reviewed
May 30, 2024
ekump
reviewed
May 30, 2024
ekump
reviewed
May 30, 2024
ekump
reviewed
May 30, 2024
ekump
reviewed
May 30, 2024
ekump
approved these changes
May 31, 2024
….bytes. * Rework send_request method in order to return a meaningful enum in which pertinent information about metrics and response is held. This favours that all metrics are managed in the same place regardless if the trace sent either to the intake or through the agent. * Limit the visibility for SendData fields in order to imporve their encapsulation. * Add default trait implementation for SendData. * Add support for the new metrics in the TraceFlusher service.
* Avoid sending tags for submitted_payloads, active_sessions and memory_usage. * Comment code managing trace_api_bytes as there is no suppor it. * Add status code to HTTP error logs. * Define constants for for literals. * Replace 'trace-chunk-*' for 'trace-chunks-*.
hoolioh
force-pushed
the
julio/APMSP-1004-add-metrics
branch
from
0ed9d3d to
07475df
Compare
hoolioh
force-pushed
the
julio/APMSP-1004-add-metrics
branch
from
07475df to
1a0aa63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for sending the following metrics:
Aside from the introduction of those new metrics a small refactor has been done on send_data.rs in order to address some technical debt from previous PRs. This changes can be summarized in:
SendDatafields.SendDataResult.TraceHeaderTagsandSendData.Motivation
In order to turn the sidecar on by default for PHP there is the need to support those metrics.