Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Add args and env parameters to the receiver #389

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

danielsn
Copy link
Contributor

What does this PR do?

Adds args and env parameters to allow clients to control that facet of the receiver

Motivation

As crashtracking is used in more places, we see use cases for setting args and env. I also cleaned up the structs.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

For Reviewers

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@danielsn danielsn requested review from a team as code owners April 11, 2024 20:52
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Apr 11, 2024
@danielsn danielsn changed the title [crashtracker] Add args and env parameters to the recevier [crashtracker] Add args and env parameters to the receiver Apr 23, 2024
Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some minor notes/comments, but no dealbreakers.

crashtracker/src/configuration.rs Outdated Show resolved Hide resolved
crashtracker/src/configuration.rs Outdated Show resolved Hide resolved
crashtracker/src/configuration.rs Show resolved Hide resolved
examples/ffi/crashtracking.c Outdated Show resolved Hide resolved
examples/ffi/crashtracking.c Outdated Show resolved Hide resolved
profiling-ffi/src/crashtracker/datatypes.rs Show resolved Hide resolved
profiling-ffi/src/crashtracker/datatypes.rs Show resolved Hide resolved
@danielsn danielsn merged commit 832b262 into main Apr 24, 2024
20 checks passed
@danielsn danielsn deleted the dsn/crashtracker-add-args branch April 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the profiling* modules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants