Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Add demangler to FFI interface #378

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Apr 2, 2024

What does this PR do?

Provides a convenient way to demangle strings using libdatadog

Motivation

.Net needs to do this.

Additional Notes

Passing strings across the FFI boundary is ugly. Any thoughts on cleaner ways to do this?

How to test the change?

Describe here in detail how the change can be validated.

For Reviewers

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@danielsn danielsn requested review from a team as code owners April 2, 2024 21:33
@github-actions github-actions bot added profiling Relates to the profiling* modules. common labels Apr 2, 2024
@danielsn danielsn force-pushed the dsn/demangle-strings branch from 7bb1311 to 6353e0f Compare April 2, 2024 21:40
Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielsn danielsn merged commit b2a4de2 into main Apr 3, 2024
19 of 20 checks passed
@danielsn danielsn deleted the dsn/demangle-strings branch April 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common profiling Relates to the profiling* modules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants