[ddtelemetry] Implement ffi code for telemetry metrics #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to have an example in C/C++ in |
gleocadie
reviewed
Feb 27, 2024
* Add comment documenting methods on the API * Add add add_points_with_tags method if extra tags are used
paullegranddc
force-pushed
the
paullgdc/ddtelemetry/only_metrics_worker
branch
from
fee12e3 to
c815bbb
Compare
bantonsson
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Add an entrypoint to the telemetry worker that doesn't send app-events such as app-started * Add ffi functions to send telemetry metrics * Add shutdown with timeout method * Add comment documenting methods on the API * Add add add_points_with_tags method if extra tags are used * Add telemetry logs and metrics example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an entrypoint to the telemetry worker that doesn't send app-events, just metrics and logs for use in languages that already have a telemetry client sending app-events, but want to send telemetry metrics from the native side
Expose telemetry metrics API to the ffi
Refactor the telemetry API to use
NonNull<Box<Type>>instead of&mut *mut Typeto represent out parameters.This doesn't have any impact on the generated C headers, or the ffi API since this types have the exact same ABI, but it expresses intent better IMO.
Motivation
This is needed because Christophe Nasarre wants to use libdatadog to send telemetry metrics from the dotnet profiler, from the native library side.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
For Reviewers
@DataDog/security-design-and-guidance.