3rd party license check #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check on the 3rd party licenses was causing issues when the registry paths were different. This is a workaround where we ignore parts of the paths.
r1viollet
force-pushed
the
r1viollet/fix_3rd_party_flakyness
branch
from
0e94fba to
6173a19
Compare
paullegranddc
approved these changes
Feb 16, 2024
bantonsson
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The check on the 3rd party licenses was causing issues when the registry paths were different. This is a workaround where we ignore parts of the paths.
Motivation
Fix 3rd party license check flakyness
Ignore differences due to path
Additional Notes
NA
How to test the change?
This is a CI change
For Reviewers
@DataDog/security-design-and-guidance.