Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or work around clippy lints #31

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Conversation

morrisonlevi
Copy link
Contributor

What does this PR do?

This fixes or works around clippy lints that exist on nightly.

Motivation

I didn't like having a broken CI job as well as a broken clippy checker if I ran it locally.

Additional Notes

Nightly is annoying but helpful.

How to test the change?

Regular tests should work.

Doing allow(clippy::get_first) or any other lint that doesn't exist on
1.60 is annoying.
@morrisonlevi morrisonlevi requested a review from a team as a code owner July 9, 2022 00:49
Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for taking care of these

@morrisonlevi morrisonlevi merged commit 7e0d038 into main Jul 12, 2022
@morrisonlevi morrisonlevi deleted the levi/nightly-clippy-lints branch July 12, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants