Instrumentation worker ffi #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullegranddc
force-pushed
the
paullgdc/ddtelemetry_ffi
branch
2 times, most recently
from
67d7364 to
fca2108
Compare
paullegranddc
force-pushed
the
paullgdc/ddtelemetry_ffi
branch
from
7040aa5 to
f8e3bfb
Compare
paullegranddc
force-pushed
the
paullgdc/ddtelemetry_ffi
branch
2 times, most recently
from
2394189 to
a126aae
Compare
paullegranddc
force-pushed
the
paullgdc/ddtelemetry_ffi
branch
from
a126aae to
fae3127
Compare
|
Rebased the branch to consolidate commits together |
|
Congratz on landing this 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a ddtelemetry-ffi crate that exposes a FFI to submit telemetry data.
The telemetry bindings support:
This ffi code includes macro_rules that generate accessors for rust on structs. For these accessors to be processed by cbindgen, we beed to use the nightly version of the toolchain.
Things that are not included, but plan to add in further PRs:
Motivation
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.