Remove flaky si_code checks

DataDog · Feb 13, 2025 · 3928344 · 3928344
1 parent 61d6721
commit 3928344
Showing 1 changed file with 0 additions and 14 deletions.
diff --git a/bin_tests/tests/crashtracker_bin_test.rs b/bin_tests/tests/crashtracker_bin_test.rs
@@ -187,22 +187,18 @@ fn test_crash_tracking_bin(
 fn assert_siginfo_message(sig_info: &Value, crash_typ: &str) {
     match crash_typ {
         "sigabrt" => {
-            assert_eq!(sig_info["si_code_human_readable"], "UNKNOWN");
             assert_eq!(sig_info["si_signo"], libc::SIGABRT);
             assert_eq!(sig_info["si_signo_human_readable"], "SIGABRT");
         }
         "sigsegv" => {
-            assert_eq!(sig_info["si_code_human_readable"], "SEGV_ACCERR");
             assert_eq!(sig_info["si_signo"], libc::SIGSEGV);
             assert_eq!(sig_info["si_signo_human_readable"], "SIGSEGV");
         }
         "sigbus" => {
-            assert_eq!(sig_info["si_code_human_readable"], "BUS_ADRALN");
             assert_eq!(sig_info["si_signo"], libc::SIGBUS);
             assert_eq!(sig_info["si_signo_human_readable"], "SIGBUS");
         }
         "sigill" => {
-            assert_eq!(sig_info["si_code_human_readable"], "UNKNOWN");
             assert_eq!(sig_info["si_signo"], libc::SIGILL);
             assert_eq!(sig_info["si_signo_human_readable"], "SIGILL");
         }
@@ -266,16 +262,11 @@ fn assert_telemetry_message(crash_telemetry: &[u8], crash_typ: &str) {
     match crash_typ {
         "sigabrt" => {
             assert!(base_expected_tags.is_subset(&tags), "{tags:?}");
-            assert!(tags.contains("si_code_human_readable:UNKNOWN"), "{tags:?}");
             assert!(tags.contains("si_signo_human_readable:SIGABRT"), "{tags:?}");
             assert!(tags.contains("si_signo:6"), "{tags:?}");
         }
         "sigbus" => {
             assert!(base_expected_tags.is_subset(&tags), "{tags:?}");
-            assert!(
-                tags.contains("si_code_human_readable:BUS_ADRALN"),
-                "{tags:?}"
-            );
             assert!(tags.contains("si_signo_human_readable:SIGBUS"), "{tags:?}");
             // SIGBUS can be 7 or 10, depending on the os.
             assert!(
@@ -285,16 +276,11 @@ fn assert_telemetry_message(crash_telemetry: &[u8], crash_typ: &str) {
         }
         "sigill" => {
             assert!(base_expected_tags.is_subset(&tags), "{tags:?}");
-            assert!(tags.contains("si_code_human_readable:UNKNOWN"), "{tags:?}");
             assert!(tags.contains("si_signo_human_readable:SIGILL"), "{tags:?}");
             assert!(tags.contains("si_signo:4"), "{tags:?}");
         }
         "sigsegv" => {
             assert!(base_expected_tags.is_subset(&tags), "{tags:?}");
-            assert!(
-                tags.contains("si_code_human_readable:SEGV_ACCERR"),
-                "{tags:?}"
-            );
             assert!(tags.contains("si_signo_human_readable:SIGSEGV"), "{tags:?}");
             assert!(tags.contains("si_signo:11"), "{tags:?}");
         }