max_returned_metrics: parse string value with fallback
#537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosroman
reviewed
Aug 23, 2024
| @@ -97,6 +97,31 @@ public void testBaselineDefaultHostname() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
carlosroman
reviewed
Aug 23, 2024
| try { | ||
| this.maxReturnedMetrics = Integer.parseInt((String) maxReturnedMetrics); | ||
| } catch (NumberFormatException e) { | ||
| log.warn("Cannot convert max_returned_metrics to integer in your instance configuration. Defaulting to '{}'.", MAX_RETURNED_METRICS); |
There was a problem hiding this comment.
This line might break the linter (waiting for it to run) so you may want to do something like this (I probably have the spaces all wrong):
Suggested change
| log.warn("Cannot convert max_returned_metrics to integer in your instance configuration. Defaulting to '{}'.", MAX_RETURNED_METRICS); | |
| log.warn( | |
| "Cannot convert max_returned_metrics to integer in your instance configuration. Defaulting to '{}'.", | |
| MAX_RETURNED_METRICS); |
carlosroman
approved these changes
Aug 23, 2024
|
Superseded by #539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR allows the use of integer string value for the
max_returned_metricsparameter. If the string cannot be parsed, falls back to default limit instead.Motivation
Recent customer case where their JMX configuration would not work once they added
max_returned_metrics. As they were using k8s annotations, they tried to use a string in the JSON instead of the integer, causing the instance not to be loaded with the error messageUnable to create instance. Please check your yaml file:{ "instances": [ { "host": "%%host%%", "port": 9999, "max_returned_metrics": "2000" } ] }instead of
{ "instances": [ { "host": "%%host%%", "port": 9999, "max_returned_metrics": 2000 } ] }With this PR, both syntaxes would work.