AMLII-1148 - Adding Unit test to check GC metrics emitted by each type of Java garbage collector #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosroman
force-pushed
the
carlosroman/jvm-gc-tests
branch
from
aca6d7d
to
0d94021
Compare
carlosroman
force-pushed
the
carlosroman/jvm-gc-tests
branch
from
0d94021
to
ba48c6d
Compare
scottopell
reviewed
Dec 14, 2023
src/test/java/org/datadog/jmxfetch/util/MisbehavingJMXServer.java
Outdated
Show resolved
Hide resolved
scottopell
reviewed
Dec 14, 2023
| } | ||
|
|
||
| @Override | ||
| public void start() { |
There was a problem hiding this comment.
I like this wrapper, good idea to wrap this up a bit more.
scottopell
reviewed
Dec 19, 2023
carlosroman
changed the title
scottopell
reviewed
Dec 20, 2023
| public void testDefaultOldGC() throws IOException { | ||
| try (final MisbehavingJMXServer server = new MisbehavingJMXServer(MisbehavingJMXServer.DEFAULT_RMI_PORT, MisbehavingJMXServer.DEFAULT_CONTROL_PORT, | ||
| MisbehavingJMXServer.DEFAULT_SUPERVISOR_PORT)) { | ||
| final List<Map<String, Object>> actualMetrics = startAngGetMetrics(server, false); |
There was a problem hiding this comment.
Suggested change
| final List<Map<String, Object>> actualMetrics = startAngGetMetrics(server, false); | |
| final List<Map<String, Object>> actualMetrics = startAndGetMetrics(server, false); |
| public void testDefaultNewGCMetricsUseParallelGC() throws IOException { | ||
| try (final MisbehavingJMXServer server = new MisbehavingJMXServer( | ||
| MisbehavingJMXServer.JDK_11, | ||
| "-XX:+UseParallelGC -Xmx128M -Xms128M")) { |
There was a problem hiding this comment.
If all of these need increased heap mem, maybe that should be the default?
| actualMetrics); | ||
| } | ||
|
|
||
| private static void assertGCMetric(final List<Map<String, Object>> actualMetrics, |
There was a problem hiding this comment.
can this be implemented in terms of the above assertGCMetric? It looks like most of the tests use the above version
|
|
||
| @Test | ||
| public void testJMXDirectBasic() throws Exception { | ||
| try (final SimpleAppContainer container = new SimpleAppContainer()){ |
There was a problem hiding this comment.
Was there any specific reason why you decided to leave in SimpleApp in addition to misbehaving-jmx-server?
| @@ -123,12 +122,16 @@ static void stopJMXServer() throws IOException, InterruptedException { | |||
| } | |||
|
|
|||
| static void startJMXServer() throws IOException { | |||
| ProcessBuilder pb = new ProcessBuilder("java", | |||
| final String misbehavingOpts = System.getenv("MISBEHAVING_OPTS"); | |||
There was a problem hiding this comment.
Can you add something to the docs about this var and what format it should have?
|
|
||
| echo "Using `java --version`" | ||
| echo "With JAVA_OPTS '${JAVA_OPTS}'" | ||
| CONTAINER_IP=`awk 'END{print $1}' /etc/hosts` |
There was a problem hiding this comment.
TIL awk keeps the last line's vars around for access in END https://www.gnu.org/software/gawk/manual/html_node/I_002fO-And-BEGIN_002fEND.html
drichards-87
approved these changes
Dec 21, 2023
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
scottopell
approved these changes
Dec 21, 2023
carlosroman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added tests for GC metrics.