Check if path exists and is nonempty before reading host files #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplanel
approved these changes
Nov 12, 2021
internal/common/common.go
Outdated
| defer f.Close() | ||
|
|
||
| r := bufio.NewReader(f) | ||
| _, err = r.ReadString('\n') |
There was a problem hiding this comment.
please use r.ReadSlice('\n') here, this would not create an unused string.Builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we mount the required
/etcfiles for host detection to a container, whenever a file isn't present on the host we end up creating an empty file in that location in the container. This can break host OS detection, so we need to make sure that when we check if a file exists, we also check that it contains data.