Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Add fabric output to event text #95

Merged
merged 2 commits into from
May 29, 2014
Merged

Add fabric output to event text #95

merged 2 commits into from
May 29, 2014

Conversation

tmichelet
Copy link
Contributor

  • don't display the stdout if not needed
  • handle multiple commands output display
  • add an example

Fixes #94

Events generated:
screen shot 2014-05-27 at 6 20 55 pm

screen shot 2014-05-27 at 6 20 34 pm

screen shot 2014-05-27 at 6 28 19 pm

screen shot 2014-05-27 at 6 27 07 pm
This last screenshot shows that the text collapses if it's too long, it's not the actual result of the example command.

- don't display the stdout if not needed
- handle multiple commands output display
- add an example
if r:
if not isinstance(r, list):
r = [r]
output = '\n\n'.join(['%s\n%s' % (res.command, res.stdout) for res in r])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you capture stderr as well?

clofresh added a commit that referenced this pull request May 29, 2014
@clofresh clofresh merged commit 9f90b39 into master May 29, 2014
@clofresh
Copy link
Contributor

great, thanks 🍔

@tmichelet tmichelet deleted the tristan/fabric-stdout branch May 29, 2014 16:19
@tmichelet
Copy link
Contributor Author

Do we plan to release soon?

@clofresh
Copy link
Contributor

Yeah, once #93 is resolved, since currently master is slightly backwards incompatible

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants