This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Dogshell| Enable the type and aggregation_key argument to post event #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,6 +149,9 @@ def _event(self, title, text, date_happened=None, handle=None, priority=None, re | |||
| if aggregation_key is not None: | |||
| body['aggregation_key'] = aggregation_key | |||
|
|
|||
| if event_type is not None: | |||
| body['source_type_name'] = event_type | |||
There was a problem hiding this comment.
source_type_name and event_type are two different fields, why not just name the parameter source_type_name?
bunelr
added a commit
that referenced
this pull request
May 7, 2014
Dogshell| Enable the type and aggregation_key argument to post event
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
Also add the possibility to specify the aggregation_key from the dogshell command line