This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Remove logging.basicConfig call #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing dogapi was results in a logging.basicConfig() call which can cause problems for application logging config later.
clofresh
added a commit
that referenced
this pull request
May 5, 2014
…cconfig Remove logging.basicConfig call
|
You're right, thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing dogapi results in a logging.basicConfig() call which can cause problems for application logging config later.
basicConfig() only takes effect once (since it only applies config changes if there are no handlers configured), so it's generally good practise to only call it in the main() of an app before any other logging happens.
Calling logging.info(..) (or other handlers) implicitly calls basicConfig anyway, so it's usually not necessary for a library to call basicConfig to get basic ERROR and WARNING level messages written to stderr if no other logging configuration has been done.