This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Add monitor and downtime APIs with integration tests. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class MonitorApi(object): | ||
|
|
||
| def monitor(self, mtype, query, name=None, message=None, options=None): |
There was a problem hiding this comment.
should we require name and message here because they're required in the backend?
There was a problem hiding this comment.
They are not actually required in the backend anymore. That was a bug initially but I have changed the backend now so it has the same logic as the alert API (choosing the query as the name if no name is given, same for message).
…t returning per-group states.
conorbranagan
added a commit
that referenced
this pull request
Nov 17, 2014
Add monitor and downtime APIs with integration tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge until new monitor UI is released